Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#451: Fallback to using webpack version instead of package.json version #452

Merged
merged 2 commits into from
Apr 23, 2021
Merged

#451: Fallback to using webpack version instead of package.json version #452

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d101cf
fix(utils): use webpack object version if package can't be required
LuudJanssen Apr 21, 2021
46f0e0b
style(utils): fix code style and ignore webpack import errors
LuudJanssen Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
style(utils): fix code style and ignore webpack import errors
  • Loading branch information
@LuudJanssen
LuudJanssen committed Apr 23, 2021
commit 46f0e0b393565aa60b4948d64bf41029f8e65fdc
9 changes: 5 additions & 4 deletions lib/utils/is-webpack-1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
// eslint-disable-next-line import/no-extraneous-dependencies
const webpackPkg = require("webpack/package.json") || {};
const webpackVersion = webpackPkg.version || require("webpack").version;
// eslint-disable-next-line import/no-extraneous-dependencies, import/no-unresolved, global-require
const webpackPkg = require('webpack/package.json') || {};
// eslint-disable-next-line import/no-extraneous-dependencies, import/no-unresolved, global-require
const webpackVersion = webpackPkg.version || require('webpack').version;

const webpackMajorVersion = parseInt(webpackVersion.split(".")[0], 10);
const webpackMajorVersion = parseInt(webpackVersion.split('.')[0], 10);

module.exports = webpackMajorVersion === 1;