#451: Fallback to using webpack version instead of package.json version
#452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuudJanssen
changed the title
webpack version instead of package.json version
|
Just noticed Prettier changed all formatting to my code standards, not yours, so I'll update the PR according to your code styles, which will probably also fix the failing pipeline. |
I desperately hope that this problem will be resolved. |
|
Hi @andresgutgon & @d3x42, I updated the PR to match the code style. I had to ignore several ESLint rules, because I didn't see another way of importing webpack. |
|
LGTM go go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (bugfix, feature, docs update, improvement)
This is a bugfix for issue #451
What is the current behavior? (You can also link to an open issue here)
Using
svg-sprite-loaderwith Next.js version 10.1.x in combination with enabling Webpack 5 results in the following error:TypeError: Cannot read property 'version' of undefinedWhat is the new behavior (if this is a feature change)?
Check if we can use the version in the
package.jsonfile and otherwise fallback to using thewebpackobject itself which contains aversionproperty.Does this PR introduce a breaking change?
No.
Please check if the PR fulfills contributing guidelines
I can't run the tests, nor the linter myself. When installing ESLint (which probably should be in the
devDependencies) I got lint errors on files I didn't touch. I checked the code style myself and everything seems to match.I'm on Windows so nor the build script nor any of the test commands worked for me.