Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jitter reproducibility in geom_jitter() #920

Merged
merged 7 commits into from
Nov 9, 2023
Merged

Jitter reproducibility in geom_jitter() #920

merged 7 commits into from
Nov 9, 2023

Conversation

RYangazov
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@alshan alshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support seed in jitterdodge as well.

@RYangazov RYangazov requested a review from alshan November 7, 2023 15:42
@RYangazov RYangazov marked this pull request as draft November 7, 2023 15:51
@@ -185,7 +188,7 @@ def position_nudge(x=None, y=None):
return _pos('nudge', x=x, y=y)


def position_jitterdodge(dodge_width=None, jitter_width=None, jitter_height=None):
def position_jitterdodge(dodge_width=None, jitter_width=None, jitter_height=None, jitter_seed=None):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In R:

position_jitterdodge(
  jitter.width = NULL,
  jitter.height = 0,
  dodge.width = 0.75,
  seed = NA
)

@RYangazov RYangazov marked this pull request as ready for review November 9, 2023 16:54
@RYangazov RYangazov requested a review from alshan November 9, 2023 16:57
@alshan alshan merged commit 11e4da5 into master Nov 9, 2023
@IKupriyanov-HORIS IKupriyanov-HORIS deleted the jitter-seed branch January 12, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants