Set null as default seed value

JetBrains · Nov 6, 2023 · 7ef7625 · 7ef7625
1 parent fa1cf4e
commit 7ef7625
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/future_changes.md b/future_changes.md
@@ -5,4 +5,4 @@
 ### Changed
 
 ### Fixed
-
+- Jitter reproducibility in geom_jitter [[#911](https://github.com/JetBrains/lets-plot/issues/911)].
diff --git a/plot-base/src/commonMain/kotlin/org/jetbrains/letsPlot/core/plot/base/pos/JitterDodgePos.kt b/plot-base/src/commonMain/kotlin/org/jetbrains/letsPlot/core/plot/base/pos/JitterDodgePos.kt
@@ -17,7 +17,7 @@ class JitterDodgePos(aesthetics: Aesthetics, groupCount: Int, width: Double?, ji
  private val myDodgePosHelper: PositionAdjustment
 
  init {
- myJitterPosHelper = JitterPos(jitterWidth, jitterHeight, seed = null)
+ myJitterPosHelper = JitterPos(jitterWidth, jitterHeight)
  myDodgePosHelper = DodgePos(aesthetics, groupCount, width)
  }
 

diff --git a/plot-base/src/commonMain/kotlin/org/jetbrains/letsPlot/core/plot/base/pos/JitterPos.kt b/plot-base/src/commonMain/kotlin/org/jetbrains/letsPlot/core/plot/base/pos/JitterPos.kt
@@ -12,7 +12,7 @@ import org.jetbrains.letsPlot.core.plot.base.GeomContext
 import org.jetbrains.letsPlot.core.plot.base.PositionAdjustment
 import kotlin.random.Random
 
-internal class JitterPos(width: Double?, height: Double?, seed: Long?) : PositionAdjustment {
+internal class JitterPos(width: Double?, height: Double?, seed: Long? = null) : PositionAdjustment {
 
  //uniform distribution
  private val myWidth: Double