Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lollipop Plot #759

Merged
merged 54 commits into from
Apr 21, 2023
Merged

Lollipop Plot #759

merged 54 commits into from
Apr 21, 2023

Commits on Apr 3, 2023

  1. Lollipop MVP.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    3c83b87 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Refactor LollipopGeom (remove AestheticsBuilder).

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    bd60540 View commit details
    Browse the repository at this point in the history

  2. Cut extra tail for lollipop.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    228e110 View commit details
    Browse the repository at this point in the history

  3. Small fix in the GeomHelper::cutTheEnd() function.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    49509f3 View commit details
    Browse the repository at this point in the history

  4. Add docstrings for the lollipop chart.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    f6bfa03 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Refactor LollipopGeom.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    fc24702 View commit details
    Browse the repository at this point in the history

  2. Update sampling for lollipops.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    cdcc142 View commit details
    Browse the repository at this point in the history

  3. Fix lollipop neck length.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    71caf98 View commit details
    Browse the repository at this point in the history

  4. Extend axes ranges to base points for the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    01eedcd View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into lollipop

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    7e3646f View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Add fatten parameter to the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    2b667b4 View commit details
    Browse the repository at this point in the history

  2. Add hints to the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    f465561 View commit details
    Browse the repository at this point in the history

  3. Fix lollipop hint.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    e0991fa View commit details
    Browse the repository at this point in the history

  4. Add custom legend key to the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    40d507c View commit details
    Browse the repository at this point in the history

  5. Add linewidth aesthetic and use it in the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    7fe5913 View commit details
    Browse the repository at this point in the history

  6. Add 'direction' parameter to the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    4e98b6d View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Merge branch 'master' into lollipop

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    fe8efed View commit details
    Browse the repository at this point in the history

  2. Apply 'alpha' parameter to the stick of the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    4c839dc View commit details
    Browse the repository at this point in the history

  3. Replace 'direction' parameter by the 'orientation' in the lollipop ge… 

    …ometry.
    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    7c033b3 View commit details
    Browse the repository at this point in the history

  4. Remove stick, if candy intersects baseline in the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    c8dcd0f View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Place candy over stick for the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    3330d96 View commit details
    Browse the repository at this point in the history

  2. Add new example in docstrings for the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    e610846 View commit details
    Browse the repository at this point in the history

  3. Add demo for the lollipop plot.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    e6964ef View commit details
    Browse the repository at this point in the history

  4. Mention the lollipop plot in the future_changes.md file.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    6dec28a View commit details
    Browse the repository at this point in the history

  5. Small fixes in lollipop.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    ad8cc1c View commit details
    Browse the repository at this point in the history

  6. Tiny fix in lollipop.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    7e3baab View commit details
    Browse the repository at this point in the history

  7. Rebuild the demo notebook for the lollipop plot.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    cfce662 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Slightly change the logic of the orientation parameter for the lollip… 

    …op geometry.
    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    1e153c2 View commit details
    Browse the repository at this point in the history

  2. Update the demo notebook for the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    aca8a3d View commit details
    Browse the repository at this point in the history

  3. Mention 'linewidth' aesthetic in the future_changes.md file.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    eda1c6c View commit details
    Browse the repository at this point in the history

  4. Refactor orientation parameter for the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    d0e18b4 View commit details
    Browse the repository at this point in the history

  5. Remove extra method from the LollipopGeom.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    7e5a686 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Refactor parsing of the 'orientation' parameter for the LollipopGeom.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    24e6028 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Add 'dir' parameter to the lollipop geometry, slightly change behavio… 

    …ur of the 'orientation' parameter.
    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    32a9fbe View commit details
    Browse the repository at this point in the history

  2. Fix error in calculations of the base point for the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    839820a View commit details
    Browse the repository at this point in the history

  3. Add sorting to the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    02e9f33 View commit details
    Browse the repository at this point in the history

  4. Refactor LollipopGeom.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    3451f28 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Refactor GeomProtoClientSide (lollipop geometry case).

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    5f994c5 View commit details
    Browse the repository at this point in the history

  2. Update cookbook for the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    e165039 View commit details
    Browse the repository at this point in the history

  3. Update aesthetics defaults for the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    c8da5a7 View commit details
    Browse the repository at this point in the history

  4. Rebuild the cookbook notebook for the lollipop geometry.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    9dd8e81 View commit details
    Browse the repository at this point in the history

  5. Tiny fixes in the lollipop plot.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    0f77bba View commit details
    Browse the repository at this point in the history

  6. Another small fix for the lollipop plot.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    196b8ca View commit details
    Browse the repository at this point in the history

  7. Update the cookbook notebook for the lollipop plot.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    043a393 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Tiny fix in the GeomProtoClientSide (error -> IllegalArgumentException).

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    1ff09b5 View commit details
    Browse the repository at this point in the history

  2. Small update in the lollipop cookbook.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    eb8bbc6 View commit details
    Browse the repository at this point in the history

  3. Tiny fix in cookbook for the geom_lollipop.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    c7136e2 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Merge branch 'master' into lollipop

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    1bc6f4e View commit details
    Browse the repository at this point in the history

  2. Refactor LollipopGeom.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    5c505bd View commit details
    Browse the repository at this point in the history

  3. Refactor: change orientation variable type in the lollipop geometry (… 

    …from Orientation to Boolean).
    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    4b0f24a View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Refactor: remove information about orientation from getBase() functio… 

    …n in the LollipopGeom.
    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    7c889ad View commit details
    Browse the repository at this point in the history

  2. Yet another improvement in the LollipopGeom.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    2207770 View commit details
    Browse the repository at this point in the history

  3. Yet another refactor of the LollipopGeom.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    7573e20 View commit details
    Browse the repository at this point in the history

  4. Transform Lollipop::candyRadius() to property.

    @ASmirnov-HORIS
    ASmirnov-HORIS committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    b9cbe31 View commit details
    Browse the repository at this point in the history