-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lollipop Plot #759
Lollipop Plot #759
Conversation
@@ -10,5 +10,5 @@ import jetbrains.datalore.plot.base.Aes | |||
import jetbrains.datalore.plot.base.DataPointAesthetics | |||
|
|||
interface WithHeight { | |||
fun heightSpan(p: DataPointAesthetics, coordAes: Aes<Double>, resolution: Double, isDiscrete: Boolean):DoubleSpan? | |||
fun heightSpan(p: DataPointAesthetics, coordAes: Aes<Double>, resolution: Double, isDiscrete: Boolean, isYOrientation: Boolean): DoubleSpan? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coordAes
takes in account isYOrientation
. Why do you need an extra parameter?
import kotlin.math.* | ||
|
||
class LollipopGeom : GeomBase(), WithWidth, WithHeight { | ||
var fatten: Double = DEF_FATTEN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try to replace var
-> val
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be problematic so let it be I guess.
|
||
See: [example notebook](https://nbviewer.org/github/JetBrains/lets-plot/blob/master/docs/f-23b/lollipop_plot.ipynb). | ||
|
||
|
||
- `stroke` aesthetic for `geom_point()`, `geom_jitter()`, `geom_qq()`, `geom_qq2()`, `geom_pointrange()`, `geom_dotplot()`, `geom_ydotplot()` and `outlier_stroke` parameter for `geom_boxplot()`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also linewidth
.
…ur of the 'orientation' parameter.
…from Orientation to Boolean).
…n in the LollipopGeom.
No description provided.