Try to fix LibreOffice class loader #5287

Siedlerchr · 2019-09-07T15:41:35Z

After a lot of googling I found some old forum thread in the deep of the open office forums which combined gave the solution.

Use sockets instead of pipes (cause jpipe is a dll/lib in the LO dir and cannot be found at class loading
Pass an URL ClassLoader as parent to the Bootstrap method.
https://technology.amis.nl/2006/07/19/getting-started-with-the-openofficeorg-api-part-ii-starting-openofficeorg-with-jars-not-in-the-ooo-install-dir/

Change in CHANGELOG.md described
Tests created for changes
Manually tested changed features in running JabRef
Screenshots added in PR description (for bigger UI changes)
Ensured that the git commit message is a good one
Check documentation status (Issue created for outdated help page at help.jabref.org?)

The problem is that it somehow doesn't load the jars from the LO path, but from our custom module

src/main/java/org/jabref/gui/openoffice/OOBibBase.java

* upstream/master: (40 commits) add env var also to mv command add branch env var move to releases somehow the env vars don't get expanded fix dirs add circle ci config for building gradle jlink remove unix again crate unix archive update install4j to 8.0.1 add install4j install option for unix installer Add MIT license field Integrate with system themes snap: Add custom gradle plugin avoid committing python cache to git Add gtk3 support remove desktop gtk3 add desktop gtk 3 Update snapcraft to java 11 will require bionic now as base Bump jaxb-xjc from 2.2.4-1 to 2.3.2 (#4956) Fix/field inheritance (#5282) added comments ...

…path parameter

Siedlerchr · 2019-09-14T17:10:56Z

Yippieh! I hacked the Bootsrap mechanism and use now sockets instead of pipes. That works yeahahw!
And I also needed to pass a UrlClassLoader

* upstream/master: Improve drag and drop (#5306)

tobiasdiez

LGTM, only two minor remarks. You also have checked in some changes to the submodules. Was this on purpose?

Moreover, can you please report the issue to the open office people and link it in our java 11 issue so that we can remove the custom bootstraper again in the long term.

tobiasdiez · 2019-09-14T22:55:47Z

src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java

- throw new IOException("Error, could not add URL to system classloader", e);
- }
+ private static void addURL(List<URL> jarList) throws IOException, ClassNotFoundException {
+ // Class<?> clazz = Class.forName("com.sun.star.comp.helper.Bootstrap", true, new ChildFirstClassLoader( jarList.toArray(new URL[0]),null ));


can this be removed now?

tobiasdiez · 2019-09-14T22:56:48Z

src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java

@@ -442,7 +427,7 @@ protected OOBibBase call() throws Exception {

 }

- private void loadOpenOfficeJars(Path configurationPath) throws IOException {
+ private List<URL> loadOpenOfficeJars(Path configurationPath) throws IOException {


I guess findOpenOfficeJars is now a better name

tobiasdiez · 2019-09-14T22:57:17Z

src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java

 // Connect
- return new OOBibBase(ooPrefs.getExecutablePath(), true, dialogService);
+
+ return new OOBibBase(jarUrls,true, dialogService);


space in arguments

fix spacing

Siedlerchr · 2019-09-15T10:27:23Z

I will open an issue at the libre office repo.
Regarding the submodules: I have no idea why these are in my commit. I tried to "reset" them and re init them but nothing changed.

tobiasdiez · 2019-09-15T11:33:40Z

Ok, please add a changelog entry and then merge!

30fb68e Create BJEDIS-ABNT-Number (#5255) aafb868 Update geochimica-et-cosmochimica-acta.csl (#5321) 60ba25f british-journal-of-anaesthesia.csl: add comma delimiter between non-sequential citations eg. 1 4 7-9 -> 1, 4, 7-9 (#5313) 67e6564 Reindent/reorder (#5318) c0d2a39 Ruby 3.0.0 (#5309) 76d60ff Update harvard-anglia-ruskin-university.csl (#5310) bc18ac9 Create journal-for-the-study-of-the-new-testament.csl (#5312) aff602c Update journal-of-food-protection.csl (#5315) 4503826 Update muscle-and-nerve.csl (#5317) 3bed58e constant redefinition 4d718a0 update documentaiton link fa99e2f add comma delimiter between succesive numbers d396f8b Allow privileged testing of PRs (#5307) 43b22c7 Update masarykova-univerzita-pravnicka-fakulta.csl, pravnik.csl, iso690-full-note-cs.csl (#5308) 8a31c1e Update copernicus-publications.csl (#5303) 96760bb Update anabases.csl (#5304) 744de6d removed locale (#5300) 7eb0d60 Update aviation-space-and-environmental-medicine.csl (#5297) 2769970 Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#5298) 51e3f4c Update harvard-university-of-bath.csl (#5299) 5fce84f Create cns-spectrums.csl (#5290) bb8082c Create journal-of-surgical-oncology.csl (#5259) 90c13ae Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#5288) 4bab1ad Update early-christianity.csl (#5289) 636ba78 Update tatup-zeitschrift-fur-technikfolgenabschatzung-in-theorie-und-… (#5291) b7cc511 Create biotechnologia.csl (#5292) 5bab881 Update journal-of-orthopaedic-trauma.csl (#5287) 5943413 Fix locales (#5285) 302bd65 Update universite-du-quebec-a-montreal-departement-dhistoire.csl (#5286) 860ae48 Add Haaga-Helia University of Applied Sciences Harvard style (#5282) c1c27de Localize Metropolia style title (#5283) 508da89 Fix presentation for Methods of Information in Medicine (#5284) 53e1d0b Create geschichte-und-gesellschaft.csl (#5216) d7ed0cb Create universite-de-geneve-departement-de-francais-moderne.csl (#5212) 80c404b Update journal-of-orthopaedic-trauma.csl (#5281) 20c143a Adding publishers' names (#5280) 6e5cd59 Update sodertorns-hogskola-oxford.csl (#5279) 52f2621 dollar-brace a260294 Create journal-of-microbiology-and-biotechnology.csl (#5277) 1fc979e Create qeios.csl (#5261) 86347b7 GH does this for us -- again, sorry guys b649589 Create experimental-biology-and-medicine.csl (#5276) 12ae0b1 Revert "tell sheldon about the job state" bdcae89 tell sheldon about the job state 1240067 Add Vegetation classification and Survey (#5271) 6f398f0 Major update to Gallia.csl (#5269) 2a74b2c Update filters.yaml (#5273) 20046d2 Update spec_helper.rb (#5272) 2ee0dd8 Create the-sociological-review.csl (#5260) 5b8d09c move filters to inert file to pacify Sheldon (#5268) e5f3315 Localize more language descriptors in style titles (#5270) bfd2942 Localize more language descriptors in style titles (#5267) 35e276f Fix variable used for the label after indication of number of pages (#5240) 60f6371 Create Universidade-do-Estado-do-Rio-de-Janeiro.csl (#5247) d8cc2ae Create the-journal-of-the-acoustical-society-of-america-numeric.csl (#5256) 92259c1 Create journal-of-financial-and-quantitative-analysis.csl (#5264) 6ba8aab Create journal-of-vestibular-research.csl (#5258) 0c88f41 Update european-journal-of-international-law.csl (#5265) cff5abc Put language descriptor within parentheses 4a62709 Update monash-university-harvard.csl (#5253) 64fd1aa Localize more language descriptors in style titles (#5262) f6519cb Localize more language descriptors in style titles (#5257) 170ccae tiny fixes for universitat-basel-iberoromanistik.csl (#5254) b7284c9 Localize more language descriptors in style titles (#5252) f4ef858 Add "Baishideng Publishing Group" dependents (#5251) 266e7c3 Make world-journal-of-hepatology.csl to bpg.csl parent (#5243) 9129098 fix small formatting issues for mclc.csl (#5229) 5d9560b Create crispr-journal.csl (#5249) a217299 Change "Czech" to "Čeština" in titles (#5248) 4fef39a Create journal-of-open-research-software.csl (#5245) 2bff1a6 Change "Dutch" to "Nederlands" in titles (#5242) f28da34 Update spec_helper.rb (#5246) e0e977c Move content from wiki pages to markdown files (#5194) 018304c Update universite-de-montreal-apa.csl (#5239) 3b83e5c Create sodertorns-hogskola-oxford.csl (#5234) 1335378 Stop notifying 8827 port on Zotero servers (#5237) f079b2a Update author-year disambiguation (#5238) 60bb0c9 Update technische-universitat-dresden-medizin.csl (#5236) e374657 Create Leidraad voor juridische auteurs 2019 (Dutch) (#5223) 0450d89 Add new style for U of Mannheim, Germanistische Linguistik (#5228) 81f0689 Create health-sports-rehabilitation-medicine.csl (#5233) c152a44 Update Gemfile.lock (#5235) 748e1eb Update geochimica-et-cosmochimica-acta.csl (#5231) 06b9ce8 Update zeitschrift-fur-theologie-und-philosophie.csl (#5230) e747cb1 haute-ecole-de-gestion-de-geneve: Make polyglot & et al changes 4cfedb7 Create universite-de-sherbrooke-histoire.csl (#5210) a96a61e Update journal-of-glaciology.csl (#5222) c6a94c9 Add Journal of Human Rights (#5227) c5c9c5f Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#5214) ffb7aa6 Create comparativ.csl (#5215) e07329a Update lancaster-university-harvard.csl (#5220) c075d41 Update mimesis-edizioni.csl (#5219) 502970a Removed space in year only citation (#5218) 13e8c6b Update acta-scientiae-veterinariae.csl (#5209) 0699da6 Remake mammallia.csl for Oct/2020 guidelines. (#5207) b2dd3fd Update journal-of-international-business-studies.csl (#5217) dd52bfe Update quaternaire.csl (#5199) ccb1b0d rebuild webpage and article-journal citations in journal-of-forensic-sciences.csl (#5203) f02f4fb Create pedosphere.csl (#5196) 70dd87a Create open-gender-journal.csl (#5198) d272998 Create the-quarterly-journal-of-economics.csl (#5197) d27cab3 fix locale issues, add cite-locator (#5206) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 30fb68e

Siedlerchr added 4 commits September 7, 2019 17:40

[WIP] Try to fix LibreOffice class loader

535a0ad

The problem is that it somehow doesn't load the jars from the LO path, but from our custom module

refactor and try with custom class loader

e81457a

try to init it after loading

4fca6a7

fix empty spaces

ecf2ff9

tobiasdiez reviewed Sep 13, 2019

View reviewed changes

src/main/java/org/jabref/gui/openoffice/OOBibBase.java Outdated Show resolved Hide resolved

Siedlerchr added 3 commits September 13, 2019 23:12

try with a custom implenention of the Boostrap class which accepts a …

e60629e

…path parameter

Hack Boostrap method of OpenOffice to use sockets instead of pipe!

f5e376c

Siedlerchr added 6 commits September 14, 2019 21:09

checkstyle

9e9a94c

Merge remote-tracking branch 'upstream/master' into fixOpenOffice

d931d4e

* upstream/master: Improve drag and drop (#5306)

update submodule?

442ddec

checkstyle rest of the document

d936951

run cleanup as well to introduce block braces

89d4981

move static variable up to fix checkstyle

56c2d78

Siedlerchr changed the title ~~[WIP] Try to fix LibreOffice class loader~~ Try to fix LibreOffice class loader Sep 14, 2019

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 14, 2019

tobiasdiez requested changes Sep 14, 2019

View reviewed changes

remove obsolete method

d935f25

fix spacing

Add changelog entry

e62af1f

Siedlerchr merged commit f30c3b9 into master Sep 15, 2019

Siedlerchr deleted the fixOpenOffice branch September 15, 2019 13:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try to fix LibreOffice class loader #5287

Try to fix LibreOffice class loader #5287

Siedlerchr commented Sep 7, 2019 •

edited

Loading

Siedlerchr commented Sep 14, 2019 •

edited

Loading

tobiasdiez left a comment

tobiasdiez Sep 14, 2019

tobiasdiez Sep 14, 2019

tobiasdiez Sep 14, 2019

Siedlerchr commented Sep 15, 2019

tobiasdiez commented Sep 15, 2019

Try to fix LibreOffice class loader #5287

Try to fix LibreOffice class loader #5287

Conversation

Siedlerchr commented Sep 7, 2019 • edited Loading

Siedlerchr commented Sep 14, 2019 • edited Loading

tobiasdiez left a comment

Choose a reason for hiding this comment

tobiasdiez Sep 14, 2019

Choose a reason for hiding this comment

tobiasdiez Sep 14, 2019

Choose a reason for hiding this comment

tobiasdiez Sep 14, 2019

Choose a reason for hiding this comment

Siedlerchr commented Sep 15, 2019

tobiasdiez commented Sep 15, 2019

Siedlerchr commented Sep 7, 2019 •

edited

Loading

Siedlerchr commented Sep 14, 2019 •

edited

Loading