Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve drag and drop #5306

Merged
merged 3 commits into from
Sep 13, 2019
Merged

Improve drag and drop #5306

merged 3 commits into from
Sep 13, 2019

Conversation

tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Sep 11, 2019

Improve drag & drop by providing the user with visual feedback what the target of the action is and suggests what the action is. Fixes #5017.

Open files by dropping them on the tab header:
image

Linking a file to an entry by dropping it onto the entry:
image

Create new entry based on file by dropping it between entries (or at the beginning/end of the list):
image


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 11, 2019
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tobiasdiez tobiasdiez merged commit 381f0f3 into master Sep 13, 2019
@tobiasdiez tobiasdiez deleted the improveDragDrop branch September 13, 2019 21:35
@koppor
Copy link
Member

koppor commented Sep 13, 2019 via email

@Siedlerchr
Copy link
Member

@koppor Open LIbrary is restricted to .bib files
The other one is import/append

Siedlerchr added a commit that referenced this pull request Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

where to drop PDF to import as new entry?
3 participants