Use System preference for light dark theme #10593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add "Use System Preference" option under General -> Appearance -> Visual Theme - Add flags to store whether user chose this option - Add SystemThemeDetector.java for auto detect system theme(to do)
- Add jSystemThemeDetector dependency in build.gradle - Implemented detector into codebase - Delete unnecessary java file
koppor
previously requested changes
Oct 28, 2023
src/main/java/org/jabref/gui/preferences/general/GeneralTabViewModel.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/gui/preferences/general/GeneralTabViewModel.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/gui/preferences/general/GeneralTabViewModel.java
Outdated
Show resolved
Hide resolved
|
I put some work into this. |
# Conflicts: # CHANGELOG.md # build.gradle
Removed whitespace
Siedlerchr
approved these changes
Nov 9, 2023
Siedlerchr
approved these changes
Nov 9, 2023
Siedlerchr
added a commit
to xuanan20020/jabref
that referenced
this pull request
Nov 10, 2023
* upstream/main: (24 commits) Add support for scite.ai (JabRef#10617) Update tests.yml (JabRef#10631) replace "SearchAll" in web search by "Search Selected" (JabRef#10611) Use System preference for light dark theme (JabRef#10593) Fix NPE in lookup identifer Add minimum requirements to CHANGELOG.md (JabRef#10628) Update to JavaFX 21.01 (JabRef#10627) Fix JabRef#10498 Create Fetcher and Transformer for ScholarArchive (JabRef#10549) fix tests Bump org.jsoup:jsoup from 1.16.1 to 1.16.2 (JabRef#10625) Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1 Bump org.fxmisc.flowless:flowless from 0.7.1 to 0.7.2 Bump com.dlsc.gemsfx:gemsfx from 1.84.0 to 1.90.0 Bump com.tngtech.archunit:archunit-junit5-api from 1.1.0 to 1.2.0 Change linter (JabRef#10614) change codecov (JabRef#10616) Add entry based on ISSN number JabRef#10124 (JabRef#10178) Enable journal information fetcher directly in popup (JabRef#10598) Make generate button wider (JabRef#10588) make openRewrite stable again ... # Conflicts: # CHANGELOG.md # src/main/resources/l10n/JabRef_en.properties
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #8729
Based on the work of #9263
In the Preference -> General -> Appearance -> Visual Theme drop-down list, I added one more option called "Use System Preference", which will change between light/dark themes according to current OS system settings. jSystemThemeDetector is used to achieve this goal.
Manually test the outcome on the MacOS. As expected, the theme will change according to the Mac appearance setting.
Screen.Recording.2023-10-28.at.12.38.01.mov
Manually test the outcome on the Windows. As expected, the theme will change according to the Windows Colour setting (Sorry I can't change the language into English for this Windows device. The three options are Light/Dark/Custom in the drop-down list). This device is relatively old, so I assume the delay is normal when changing themes.
video1845810326.mp4
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)