Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make generate button wider #10588

Merged
merged 11 commits into from
Nov 2, 2023
Merged

Make generate button wider #10588

merged 11 commits into from
Nov 2, 2023

Conversation

JMS063
Copy link
Contributor

@JMS063 JMS063 commented Oct 26, 2023 •
edited by ThiloteE
Loading

Fixes #10507

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.
    Screenshot 2023-10-20 at 12 25 14
    Screenshot 2023-10-20 at 12 25 19

@koppor
Copy link
Member

koppor commented Oct 26, 2023

I fixed the merge conflicts using GitHub - then the check will start to run. Please pull @JMS063

@Siedlerchr Siedlerchr changed the title fixed issue#10507 Make generate button wider Oct 26, 2023
@Siedlerchr Siedlerchr requested a review from calixtus October 26, 2023 18:34
@calixtus
Copy link
Member

Please do not add css directly in the code, but add a style class to the button and put the css into base.css in the root directory. This way the button can be customized in a theme and is not fixed to a certain layout. Also do not use px values except its important to set some exact size. To keep JabRef scalable proportional to font size you need to use em values. See https://docs.oracle.com/javase/8/javafx/api/javafx/scene/doc-files/cssref.html#typelength

@JMS063
Copy link
Contributor Author

JMS063 commented Oct 27, 2023

Understood, I will do this issue again. Thanks for the comment!

@ThiloteE ThiloteE added the ui label Oct 28, 2023
JMS063
JMS063 commented Oct 29, 2023
View reviewed changes
Copy link
Contributor Author

@JMS063 JMS063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi there, I updated the method to fix this issue

@Siedlerchr Siedlerchr enabled auto-merge November 2, 2023 20:19
@Siedlerchr Siedlerchr added this pull request to the merge queue Nov 2, 2023
Merged via the queue into JabRef:main with commit ec81fc6 Nov 2, 2023
17 checks passed
Siedlerchr added a commit to guipmenezes/jabref that referenced this pull request Nov 4, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-issue-10124
08211ef 
* upstream/main:
  Make generate button wider (JabRef#10588)
  make openRewrite stable again
  Rename cleanup_pr.yml to cleanup-pr.yml
  Changelog
  Fix failing fetcher tests (JabRef#10613)
  ShortDoi
Siedlerchr added a commit that referenced this pull request Nov 4, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into jabrefonline
7631a53 
* upstream/main: (1565 commits)
  Enable journal information fetcher directly in popup (#10598)
  Make generate button wider (#10588)
  make openRewrite stable again
  Rename cleanup_pr.yml to cleanup-pr.yml
  Changelog
  Fix failing fetcher tests (#10613)
  ShortDoi
  Fix CHANGELOG.md
  Bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (#10607)
  Fix issue #9306: Move "Open only one instance of JabRef" preference option to somewhere else (#10602)
  Update README.md (#10604)
  Bump me.champeau.jmh from 0.7.1 to 0.7.2
  Bump org.beryx.jlink from 3.0.0 to 3.0.1
  Bump com.dlsc.gemsfx:gemsfx from 1.82.0 to 1.84.0
  Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.0 to 2.21.1
  Synchronize scrollbars in the change resolver dialog (#10587)
  Add button for a user to reset the cite command to the default value. (#10580)
  openrerwrite
  Update .github/PULL_REQUEST_TEMPLATE.md
  Update PULL_REQUEST_TEMPLATE.md
  ...

# Conflicts:
#	.devcontainer/devcontainer.json
#	build.gradle
#	src/main/java/org/jabref/gui/DefaultInjector.java
#	src/main/java/org/jabref/gui/libraryproperties/general/GeneralProperties.fxml
#	src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesView.java
#	src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesViewModel.java
#	src/main/java/org/jabref/logic/exporter/MetaDataSerializer.java
#	src/main/java/org/jabref/logic/importer/util/MetaDataParser.java
#	src/main/java/org/jabref/model/metadata/MetaData.java
#	src/main/java/org/jabref/preferences/JabRefPreferences.java
Siedlerchr added a commit to liyou969/jabref that referenced this pull request Nov 4, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into ScholarArchiveFetcher
c2467cd 
* upstream/main: (44 commits)
  change codecov (JabRef#10616)
  Add entry based on ISSN number JabRef#10124 (JabRef#10178)
  Enable journal information fetcher directly in popup (JabRef#10598)
  Make generate button wider (JabRef#10588)
  make openRewrite stable again
  Rename cleanup_pr.yml to cleanup-pr.yml
  Changelog
  Fix failing fetcher tests (JabRef#10613)
  ShortDoi
  Fix CHANGELOG.md
  Bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (JabRef#10607)
  Fix issue JabRef#9306: Move "Open only one instance of JabRef" preference option to somewhere else (JabRef#10602)
  Update README.md (JabRef#10604)
  Bump me.champeau.jmh from 0.7.1 to 0.7.2
  Bump org.beryx.jlink from 3.0.0 to 3.0.1
  Bump com.dlsc.gemsfx:gemsfx from 1.82.0 to 1.84.0
  Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.0 to 2.21.1
  Synchronize scrollbars in the change resolver dialog (JabRef#10587)
  Add button for a user to reset the cite command to the default value. (JabRef#10580)
  openrerwrite
  ...
Siedlerchr added a commit to xuanan20020/jabref that referenced this pull request Nov 10, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-348
373dec5 
* upstream/main: (24 commits)
  Add support for scite.ai (JabRef#10617)
  Update tests.yml (JabRef#10631)
  replace "SearchAll" in web search by "Search Selected" (JabRef#10611)
  Use System preference for light dark theme (JabRef#10593)
  Fix NPE in lookup identifer
  Add minimum requirements to CHANGELOG.md (JabRef#10628)
  Update to JavaFX 21.01 (JabRef#10627)
  Fix JabRef#10498 Create Fetcher and Transformer for ScholarArchive (JabRef#10549)
  fix tests
  Bump org.jsoup:jsoup from 1.16.1 to 1.16.2 (JabRef#10625)
  Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1
  Bump org.fxmisc.flowless:flowless from 0.7.1 to 0.7.2
  Bump com.dlsc.gemsfx:gemsfx from 1.84.0 to 1.90.0
  Bump com.tngtech.archunit:archunit-junit5-api from 1.1.0 to 1.2.0
  Change linter (JabRef#10614)
  change codecov (JabRef#10616)
  Add entry based on ISSN number JabRef#10124 (JabRef#10178)
  Enable journal information fetcher directly in popup (JabRef#10598)
  Make generate button wider (JabRef#10588)
  make openRewrite stable again
  ...

# Conflicts:
#	CHANGELOG.md
#	src/main/resources/l10n/JabRef_en.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@calixtus calixtus Awaiting requested review from calixtus

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import by id: make button larger
6 participants
@JMS063 @koppor @calixtus @Siedlerchr @ThiloteE @JMS-crypto