Add option to link against non-catkin librealsense #204
Conversation
|
ping. |
There was a problem hiding this comment.
Sorry, we were in the middle of a regression which needed to be completed before merging new code.
I also want to try a few test builds to approve possible fails in the ROS Build farm.
The code looks okay to me, but please rebase this branch as there have been minor updates.
In OpenEmbedded setups where both meta-ros and meta-intel-realsense layers are used it's problematic to avoid two copies of librealsense installed onto an embedded target: one catkit-based installed under /opt/ros and one other installed to a standard system location. This patch adds an option making realsense_camera link against librealsense provided by the host system. By default the currently existing behavior is preserved. Signed-off-by: Dmitry Rozhkov <[email protected]>
roslint depends on catkin_run_tests_target() which is defined only when CATKIN_ENABLE_TESTING is True. Thus run roslint functions in CMakeLists.txt only when testing is enabled. Signed-off-by: Dmitry Rozhkov <[email protected]>
|
|
Somehow 701f939 lets our Travis CI fail due to see https://travis-ci.org/ipa320/cob_robots/jobs/212986198#L6578 our travis.yml can be seen here: https://github.com/ipa320/cob_robots/blob/indigo_dev/.travis.yml Submitting an issue seems to be blocked somehow... |
|
There appears to be some race condition in the change. |
In OpenEmbedded setups where both
meta-rosandmeta-intel-realsenselayers are used it's problematic to avoid two copies of librealsense installed onto an embedded target: one catkit-based installed under/opt/rosand one other installed to a standard system location.This patch adds an option making realsense_camera link against librealsense provided by the host system.
By default the currently existing behavior is preserved.