Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple mapper example #373

Merged
merged 13 commits into from
Nov 28, 2023
Merged

Add simple mapper example #373

merged 13 commits into from
Nov 28, 2023

Conversation

knmcguire
Copy link
Collaborator

fixes #92

In draft until flight tested, then I'll fix flake8 and docs as well.

@knmcguire
Copy link
Collaborator Author

Just did a flight test but there is some problem the map building :) probably need tot look at the retrieval of the ranges.

@knmcguire knmcguire marked this pull request as ready for review November 23, 2023 14:06
@knmcguire
Copy link
Collaborator Author

managed to fix the mapping issues. It was a matter of the range order being wrong. This has been flight tested now and i've added a portion to the tutorials.

@whoenig whoenig self-requested a review November 23, 2023 19:54
@whoenig whoenig removed their assignment Nov 23, 2023
@knmcguire knmcguire merged commit 6961278 into main Nov 28, 2023
3 checks passed
@knmcguire knmcguire deleted the add-simple-mapper branch June 24, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement simple mapper node
2 participants