Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix symlink issue in crazyflie_examples #87

Closed
knmcguire opened this issue Oct 6, 2022 · 2 comments · Fixed by #111
Closed

Fix symlink issue in crazyflie_examples #87

knmcguire opened this issue Oct 6, 2022 · 2 comments · Fixed by #111
Labels
enhancement New feature or request

Comments

@knmcguire
Copy link
Collaborator

Currently, if anybody changes anything in crazyflie_examples's launch file, config files or data files, they will need to reinstall with colcon build which is annoying.

Currently I've added a warning to the text in #86, but there are other things we can do:

Anyway, this issue will also warn crazyswarm2 users that this is still a problem.
@knmcguire knmcguire added the enhancement New feature or request label Oct 6, 2022
@whoenig
Copy link

whoenig commented Oct 6, 2022

What do you mean by "unsuccessful" - did it not build, or did the problem remain? I am pretty sure I have used the cmake-trick in other projects successfully.

whoenig added a commit that referenced this issue Nov 15, 2022
@whoenig
examples: switch to cmake for symlink-install
b8d46a0 
Workaround for colcon/colcon-core#407

Fixes #87
@knmcguire
Copy link
Collaborator Author

Yeah what I meant with unsuccessful is that it didn't build for me, but I probably forgot something in the pipeline of implementing it.

I'll review the current PR!

@knmcguire knmcguire linked a pull request Nov 16, 2022 that will close this issue
Issue87 #111
Merged
whoenig added a commit that referenced this issue Nov 17, 2022
@whoenig
Issue87 (#111)
fd778f3 
* examples: switch to cmake for symlink-install

Workaround for colcon/colcon-core#407

Fixes #87
boomer319 pushed a commit to boomer319/verrueckterschwarm2 that referenced this issue Nov 25, 2023
@whoenig
Issue87 (IMRCLab#111)
9ecc718 
* examples: switch to cmake for symlink-install

Workaround for colcon/colcon-core#407

Fixes IMRCLab#87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue87 IMRCLab/crazyswarm2
2 participants
@whoenig @knmcguire