Update Spanish Translation #2673
Conversation
New Spanish translation, old one was incomplete. Before approving this PR, make sure this merges correctly. I was unable to get the locales files through Git, so there may be issues when merging.
|
|
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/7zu3QqGzv75c7LcmPZdygComb3RT |
matteovivona
requested review from
a team,
morrme and
cpondoc
and removed request for
a team
There was a problem hiding this comment.
Everything looks good on my end! Two things:
- Not sure if you have to re-clone the repository or simply do something like a
git pull, but the files should be located withinsrc/shared/locales/es.Most of the files actually already exist, although you may need to create some new files in order to complete all of the translations and stay up to date with the most recent version of the front-end. - I would just look again at all of the translations, if you get the time. All in all, though, these look great!
| new: 'Nuevo', | ||
| list: 'Enumerar', | ||
| search: 'Buscar', | ||
| confirmDelete: 'Borrar Confirmación', |
There was a problem hiding this comment.
Not sure how many translations you want to add, but looking strictly at the English translations, it appears as though you are missing a couple within actions/index.ts. Specifically, look at:
- next
- previous
- page
- add
- view
- logout
| import sex from './sex' | ||
| import labs from './labs' | ||
|
|
||
| export default { |
There was a problem hiding this comment.
Similar to earlier issue, but if we are talking strictly in terms of being comprehensive, I believe you are missing a couple of translation folders. Specifically, terms such as bloodType and medications are missing. I would also refer to the full English translations here: https://github.com/HospitalRun/hospitalrun-frontend/blob/master/src/shared/locales/enUs/translations/index.ts.
| @@ -0,0 +1,30 @@ | |||
| export default { | |||
| labs: { | |||
| label: 'Pruebas de laboratorio', | |||
There was a problem hiding this comment.
I may leave a comment on a couple of these to link you to the English translation files in shared/locales to point you to any incompleted fields :)
https://github.com/HospitalRun/hospitalrun-frontend/blob/master/src/shared/locales/enUs/translations/labs/index.ts
|
@morrme Any other thoughts on this PR? |
matteovivona
added
the
in progress
New Spanish translation, old one was incomplete.
Before approving this PR, make sure this merges correctly. I was unable to get the locales files through Git, so there may be issues when merging.
Changes proposed in this pull request:
Newly added dependencies with Bundlephobia links:
n/a, did not modify code.