test: migrate tests to React Testing Library #2516

JacobMGEvans · 2020-12-15T01:10:17Z

We will keep this PR open and ongoing for maintainers to track the progress in realtime as the branches get merged into the forked master.

gitpod-io · 2020-12-15T01:10:20Z

vercel · 2020-12-15T01:10:22Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/lyv8m3nfi
✅ Preview: https://hospitalrun-frontend-git-fork-kcdraidgroup-master.hospitalrun.vercel.app

JacobMGEvans · 2020-12-15T01:29:05Z

@marcosvega91 Just pinging you for reference.

package.json

src/setupTests.js

src/__tests__/App.test.tsx

src/__tests__/page-header/button-toolbar/ButtonToolBar.test.tsx

src/__tests__/HospitalRun.test.tsx

src/__tests__/settings/Settings.test.tsx

src/__tests__/HospitalRun.test.tsx

src/__tests__/labs/Labs.test.tsx

src/__tests__/imagings/Imagings.test.tsx

Refactor to remove querySelector calls where possible

…rsonmodal-integration Pull AddRelatedPersonModal tests out into integration tests

src/__tests__/labs/ViewLabs.test.tsx

blestab · 2021-01-14T06:53:41Z

src/__tests__/incidents/report/ReportIncident.test.tsx

- expect(descriptionInput.prop('isInvalid')).toBeTruthy()
- expect(descriptionInput.prop('feedback')).toEqual(error.description)
- })
+ // ! Remove test? Save button is always rendered regardless of input values


I am guessing the jury is still out on this one in terms of whether or not this is still needed? Any reason we might no longer want it?

I think I left that comment (I use Better Comments and that bang at the start is something I do lol)

@nobrayner thoughts on this test?

That was me - I'll make an issue for it

blestab · 2021-01-14T07:00:11Z

src/__tests__/patients/allergies/AllergiesList.test.tsx

- wrapper.update()
- return { wrapper: wrapper as ReactWrapper, history }
+ ),
+ }
 }

 it('should render a list of allergies', async () => {
 const expectedAllergies = [{ id: '456', name: 'some name' }]


Just a question on recommendation in terms of naming conventions. In some tests we use variables named as mockSomething , in other cases expectedSomething while other times we dont have a prefix so we just have something as the variable name.

Do you have recommendations/best practice advice when it comes to naming variables in tests?

My suggestion is whatever makes sense. I generally stick with "mock" if I really want to differentiate if the variable or value is fake, however, I don't generally use expected mainly because the expect() tells you what is being asserted/expected

@nobrayner ?

Hmm... I was probably the one putting out most of the expected*.

The convention I follow is:

If I am mocking something out, rename it to mock*

If it is data I am using for assertions, label it as expected*

I also use expected* even if it is the data being returned from a mock.

I've find this helps me reason with the code a lot easier, as it helps give expectation hints to me when I revisit later.

blestab · 2021-01-14T08:24:53Z

src/__tests__/patients/allergies/ViewAllergy.test.tsx

 const patient = {
 id: 'patientId',
- allergies: [{ id: '123', name: 'some name' }],
+ allergies: [{ id: '123', name: 'cats' }],


Oh how can someone be allergic to cute cats 😺😺

blestab · 2021-01-14T08:26:48Z

src/__tests__/patients/care-goals/CareGoalForm.test.tsx

- expect(descriptionInput.prop('label')).toEqual('patient.careGoal.description')
- expect(descriptionInput.prop('isRequired')).toBeTruthy()
- expect(descriptionInput.prop('value')).toBe(careGoal.description)
+ // TODO: not using built-in form accessibility features yet: required attribute


Adding a comment here so that we don't forget this TODO

@nobrayner @codyarose this might be a good start for issues

blestab · 2021-01-14T12:06:47Z

src/__tests__/patients/care-goals/CareGoalForm.test.tsx

+ expect(dueDatePicker).toBeInTheDocument()
+ expect(noteInput).toBeInTheDocument()
+
+ // TODO: not using built-in form accessibility features yet: HTMLInputElement.setCustomValidity()


Just adding this here so we dont forget the TODO

@nobrayner @codyarose this might be a good start for issues

jackcmeyer

This is awesome! Thanks everyone for their Diligent 'n Dedicated (DnD 😉) work.

blestab

Just some commented out code and a todo which we can create an issue for. But otherwise looking good. Thank you so much for all the effort.

blestab · 2021-01-15T08:59:59Z

src/__tests__/patients/care-plans/CarePlanForm.test.tsx

+ expect(intentInput).toHaveClass('is-invalid')
+ // expect(intentInput.nextSibling).toHaveTextContent(
+ // expectedError.intent,
+ // )


May we remove commented out code

blestab · 2021-01-15T09:01:52Z

src/__tests__/patients/diagnoses/DiagnosisForm.test.tsx

+ expect(visitSelectorLabel.title).not.toBe('This is a required input')
+ })
+
+ // it.only('should call the on change handler when visit changes', () => {


Is this one still a work in progress or to be removed?

blestab · 2021-01-15T09:04:12Z

src/__tests__/patients/labs/LabsList.test.tsx

@@ -25,16 +23,16 @@ const expectedLabs = [
 rev: '1',
 patient: '1234',
 requestedOn: new Date(2020, 1, 1, 9, 0, 0, 0).toISOString(),
- requestedBy: 'someone',
- type: 'lab type',
+ requestedBy: 'Dr Strange',


mmm i don't know if i want my labs being requested by Dr Strange LOL

src/__tests__/patients/new/NewPatient.test.tsx

src/__tests__/patients/care-goals/CareGoalForm.test.tsx

JacobMGEvans · 2021-01-15T14:09:48Z

@jackcmeyer @blestab I signed the CLA on behalf of the Raid and I can get a few more people to sign it however there is no way I can get all 25+ people to sign it.

vercel bot had a problem deploying to Preview December 15, 2020 01:10 Failure

vercel bot had a problem deploying to Preview December 15, 2020 01:13 Failure

vercel bot deployed to Preview December 15, 2020 01:34 View deployment

vercel bot deployed to Preview December 15, 2020 04:48 View deployment

Aprillion reviewed Dec 15, 2020

View reviewed changes

package.json Show resolved Hide resolved

src/setupTests.js Outdated Show resolved Hide resolved

src/__tests__/App.test.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview December 15, 2020 21:00 View deployment

vercel bot deployed to Preview December 16, 2020 13:55 View deployment

matteovivona assigned fox1t and jackcmeyer Dec 16, 2020

matteovivona added in progress indicates that issue/pull request is currently being worked on v2.x labels Dec 16, 2020

matteovivona added this to In progress in Version 2.0 via automation Dec 16, 2020

matteovivona added this to the v2.0 milestone Dec 16, 2020

vercel bot deployed to Preview December 16, 2020 14:49 View deployment

vercel bot deployed to Preview December 16, 2020 17:03 View deployment

vercel bot deployed to Preview December 16, 2020 22:01 View deployment

vercel bot deployed to Preview December 16, 2020 22:03 View deployment

vercel bot deployed to Preview December 17, 2020 01:07 View deployment

jackcmeyer reviewed Dec 17, 2020

View reviewed changes

src/__tests__/page-header/button-toolbar/ButtonToolBar.test.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview December 17, 2020 02:19 View deployment

vercel bot deployed to Preview December 17, 2020 03:54 View deployment

vercel bot deployed to Preview December 17, 2020 04:34 View deployment

vercel bot deployed to Preview December 17, 2020 05:38 View deployment

vercel bot deployed to Preview December 17, 2020 17:28 View deployment

jackcmeyer reviewed Dec 17, 2020

View reviewed changes

src/__tests__/HospitalRun.test.tsx Show resolved Hide resolved

jackcmeyer suggested changes Dec 17, 2020

View reviewed changes

src/__tests__/settings/Settings.test.tsx Outdated Show resolved Hide resolved

src/__tests__/HospitalRun.test.tsx Show resolved Hide resolved

src/__tests__/labs/Labs.test.tsx Outdated Show resolved Hide resolved

src/__tests__/imagings/Imagings.test.tsx Show resolved Hide resolved

vercel bot deployed to Preview December 18, 2020 07:27 View deployment

codyarose and others added 5 commits January 13, 2021 23:21

test: refactor to remove querySelector calls

4860ebb

test: removed unused imports

6f3567c

fix: increase timeout

4e7e446

test: add back more semantic spinner queries

1ea596f

Merge pull request #273 from codyarose/codyarose_RemoveQuerySelectors

ac4e1e9

Refactor to remove querySelector calls where possible

vercel bot deployed to Preview January 14, 2021 06:29 View deployment

Merge pull request #270 from kcdraidgroup/juhanakristian-addrelatedpe…

a5f3b13

…rsonmodal-integration Pull AddRelatedPersonModal tests out into integration tests

vercel bot deployed to Preview January 14, 2021 06:31 View deployment

blestab reviewed Jan 14, 2021

View reviewed changes

JacobMGEvans mentioned this pull request Jan 14, 2021

Tests pass even if they fail #2287

Closed

2 tasks

nobrayner mentioned this pull request Jan 14, 2021

Duplicate Patient Modal cannot be triggered #2546

Open

codyarose mentioned this pull request Jan 15, 2021

ReportIncident save button always rendered #2548

Open

jackcmeyer approved these changes Jan 15, 2021

View reviewed changes

matteovivona requested a review from fox1t January 15, 2021 08:48

blestab suggested changes Jan 15, 2021

View reviewed changes

blestab requested review from blestab and removed request for fox1t January 15, 2021 09:12

blestab approved these changes Jan 15, 2021

View reviewed changes

blestab changed the title ~~RTL Conversion -- Ongoing Pull Request~~ test: migrate tests to React Testing Library Jan 15, 2021

matteovivona merged commit 660a895 into HospitalRun:master Jan 15, 2021

Version 2.0 automation moved this from In progress to Done Jan 15, 2021

This was referenced Feb 21, 2021

Help wanted sindresorhus/np#320

Open

Refactor Class Components to use Hooks HorusGoul/atom-pwa#24

Closed

This was referenced Mar 11, 2021

TypeScript Complete Conversion plouc/nivo#1446

Closed

Complete TypeScript Conversion - Raid nextauthjs/next-auth#1508

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: migrate tests to React Testing Library #2516

test: migrate tests to React Testing Library #2516

JacobMGEvans commented Dec 15, 2020

gitpod-io bot commented Dec 15, 2020 •

edited

vercel bot commented Dec 15, 2020 •

edited

JacobMGEvans commented Dec 15, 2020

blestab Jan 14, 2021

JacobMGEvans Jan 15, 2021

codyarose Jan 15, 2021

blestab Jan 14, 2021

JacobMGEvans Jan 14, 2021

JacobMGEvans Jan 15, 2021

nobrayner Jan 15, 2021 •

edited

blestab Jan 14, 2021

blestab Jan 14, 2021

JacobMGEvans Jan 14, 2021

blestab Jan 14, 2021

JacobMGEvans Jan 14, 2021

jackcmeyer left a comment

blestab left a comment

blestab Jan 15, 2021

blestab Jan 15, 2021

blestab Jan 15, 2021

JacobMGEvans commented Jan 15, 2021 •

edited

test: migrate tests to React Testing Library #2516

test: migrate tests to React Testing Library #2516

Conversation

JacobMGEvans commented Dec 15, 2020

gitpod-io bot commented Dec 15, 2020 • edited

vercel bot commented Dec 15, 2020 • edited

JacobMGEvans commented Dec 15, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nobrayner Jan 15, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jackcmeyer left a comment

Choose a reason for hiding this comment

blestab left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JacobMGEvans commented Jan 15, 2021 • edited

gitpod-io bot commented Dec 15, 2020 •

edited

vercel bot commented Dec 15, 2020 •

edited

nobrayner Jan 15, 2021 •

edited

JacobMGEvans commented Jan 15, 2021 •

edited