Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript support #20

Closed
turneand opened this issue Mar 25, 2021 · 3 comments · Fixed by #21
Closed

TypeScript support #20

turneand opened this issue Mar 25, 2021 · 3 comments · Fixed by #21

Comments

@turneand
Copy link
Contributor

Great library, looking to use it in some of our existing applications.

However, we're all TypeScript so was wondering if you'd be interested in adding a types file, or migrating the app in its entirety over to typescript? More than happy to contribute a PR if you have a preference.

@HW13
Copy link
Member

HW13 commented Mar 25, 2021

Hey, thanks @turneand!

I think the preference right now would be adding a types file rather than a complete migration. If you'd be willing to submit a PR for that, it would be much appreciated. 🙏

@JacobMGEvans
Copy link

Greetings,
If you change your mind about a complete migration feel free to contact us as well 😄. If you are interested we can "Raid" your repository, there would be one big PR from our Organization, for a large specific task/problem domain; in this case TS conversion.

We would need a maintainer as a point of contact, we prefer using Discord https://discord.gg/xkdkAJZsBR

Let me know if you are interested.
You can read more about what we are doing here: https://github.com/OpenSourceRaidGuild/tutorial-quest
This is also an example of how we work and the workflow: HospitalRun/hospitalrun-frontend#2516

cc: @nobrayner @mpeyper @Aprillion

@HW13 HW13 linked a pull request Mar 30, 2021 that will close this issue
@HW13
Copy link
Member

HW13 commented Mar 31, 2021

Thanks @JacobMGEvans, appreciate the offer! We'll keep that in mind if we decide to migrate in the future 👍

@HW13 HW13 closed this as completed in #21 Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants