Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lora.json in site-packages, feat: python 3.11 support, refactor: code cleanup + mypy compliance #59

Merged
merged 15 commits into from
Aug 2, 2023
Merged

fix: lora.json in site-packages, feat: python 3.11 support, refactor: code cleanup + mypy compliance #59

merged 15 commits into from
Aug 2, 2023

Conversation

tazlin
Copy link
Member

@tazlin tazlin commented Aug 2, 2023 •
edited
Loading

fix: lora.json in site-packages:

feat: python 3.11 support

  • The use of the idiom class classname(str, Enum) has been replaced with the strenum package, to support both python 3.10 + 3.11.
  • These enum classes now use auto()

refactor: code cleanup + mypy compliance

  • Many potentially unset or unbound variables now handled explictly
  • Certain corner cases errors now still occur, but with context as for why.
  • Numerous type hints corrected or made more accurate
  • Several # type: ignore mypy meta-commands are present. Any outside comfy_horde.py are probably in need of some attention.

db0 and others added 15 commits July 12, 2023 16:40
@db0
Tests: negative lora model strength values
f91ae22
@db0
Merge pull request #50 from Haidra-Org/negloratest
a4363aa 
Tests: negative lora model strength values
@tazlin
refactor: mypy assisted cleanup, py 3.11 support
9912d03 
Fixes:
- many potentially unbound variables
- cases where an attr/property may be `None` but were not checked
- pytests yield generator typehints

Adds:
- Py 3.11 support by removing reliance on `(str, Enum)` and instead using `StrEnum` to maintain 3.10 support
@tazlin
chore: standardize req.dev.txt with other haidra projects
1294ab0
@tazlin
fix: do not include "tests" as a package in build
4074167
@tazlin
tests: warm loaded models now are unloaded at test run start
749e577
@tazlin
style: lint fix
bc88d27
@tazlin
tests: add clearer asserts to img2img test
831a31f
@tazlin
fix: bring lora test in line with recent refactors
8694c98
@tazlin
fix: renamed old param in neg model power test
6e9757d
@tazlin
Merge pull request #53 from Haidra-Org/regen-changes
c5d72c7 
refactor: Code cleanup, py 3.11 support, better type hints, mypy assisted bug squashing
@Efreak
feat: Loras random "any" and allows "all" trigger (#56)
e7a7bad
@tazlin
fix: store lora.json with other model reference files
086923b
@tazlin
fix: path type for lora mm mixup
3ce4626
@tazlin
Merge pull request #58 from Haidra-Org/57-lorajson-stored-in-site-pac…
c6ca562 
…kages-folder

fix: store lora.json with other model reference files
@tazlin tazlin added the release:patch Version _._.x label Aug 2, 2023
@tazlin tazlin merged commit 505d7cb into releases Aug 2, 2023
1 check passed
@tazlin tazlin mentioned this pull request Aug 2, 2023
Merged
tazlin added a commit that referenced this pull request Aug 2, 2023
@tazlin
Merge pull request #63 from Haidra-Org/main
394cc82 
Merge #59 take 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:patch Version _._.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tazlin @db0 @Efreak