Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Code cleanup, py 3.11 support, better type hints, mypy assisted bug squashing #53

Merged
merged 8 commits into from
Jul 21, 2023

Conversation

tazlin
Copy link
Member

@tazlin tazlin commented Jul 17, 2023

Edit: This PR has been narrowed in scope to bring main up to date with the changes as of now for the purposes of collaboration.

@tazlin tazlin changed the title feat: updated packaged ComfyUI, single threaded worker support, other continued improvements refactor: Code cleanup, py 3.11 support, better type hints, mypy assisted bug squashing Jul 21, 2023
@tazlin tazlin marked this pull request as ready for review July 21, 2023 13:03
Fixes:
- many potentially unbound variables
- cases where an attr/property may be `None` but were not checked
- pytests yield generator typehints

Adds:
- Py 3.11 support by removing reliance on `(str, Enum)` and instead using `StrEnum` to maintain 3.10 support
@tazlin tazlin merged commit c5d72c7 into main Jul 21, 2023
1 check failed
@tazlin tazlin deleted the regen-changes branch July 21, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant