Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mostly fixing tests and deployment documentation with a hint of containerization #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vincepower
Copy link

List of what has changed in this PR:

  • no core code has been touched
  • test cases should run in CircleCI now
  • Updating README.md to include deployment instructions with and without a container. I was curious about this project and figured if I was going to deploy it, I might as well document it. My daughter was using it in one of Juno's JavaScript classes.
  • Adding a working Dockerfile to support running this in a container. Containers are great because they restart automatically when they crash, oh and you could deploy this in like DO's k8s for instance scalability.

This is the cleaner version of this PR, I just had too many commits in my late attempt as I messed around with testing on CircleCI.

@vincepower vincepower mentioned this pull request Sep 18, 2021
@vincepower
Copy link
Author

Tagging @brentc just so this has some visibility.

@brentc
Copy link
Contributor

brentc commented Dec 1, 2021

@colindamelio something for you to consider!

@vincepower Sorry, this slipped through the cracks and I never had time to consider it. I'm no longer with Juno, so it's not my call any more. Looks like it has some potential though.

@vincepower
Copy link
Author

@brentc Cool, thanks. I just assumed you were based on your description that showed up (CTO of Juno)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants