Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce pipeline crate #4109

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

shuiyisong
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This is a pre-pr for #4014 to introduce https://github.com/GreptimeTeam/pipeline into src/pipeline/src/etl. The code is not referred anywhere now.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@shuiyisong shuiyisong requested a review from a team as a code owner June 5, 2024 13:52
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.16%. Comparing base (16b85b0) to head (c32b126).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4109      +/-   ##
==========================================
- Coverage   85.47%   85.16%   -0.31%     
==========================================
  Files         993      993              
  Lines      173751   173751              
==========================================
- Hits       148505   147968     -537     
- Misses      25246    25783     +537     

@tisonkun tisonkun changed the title chore: introduce pipeline crate feat: introduce pipeline crate Jun 5, 2024
@tisonkun
Copy link
Contributor

tisonkun commented Jun 5, 2024

This is of course a new feature rather than "chore" :D

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original pipeline repo has a detailed pr-review history. Just merge this mv operation

@waynexia waynexia enabled auto-merge June 5, 2024 17:08
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a huge PR. But let's move forward.

@waynexia waynexia added this pull request to the merge queue Jun 5, 2024
Merged via the queue into GreptimeTeam:main with commit 2ade511 Jun 5, 2024
38 checks passed
@waynexia waynexia deleted the chore/introduce_pipeline branch June 5, 2024 17:38
};
use crate::etl::value::{Map, Value};

pub(crate) const PROCESSOR_CMCD: &str = "cmcd";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "cmcd" stand for?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found "Common Media Client Data" below now :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants