Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fuzz): sort inserted rows with primary keys and time index #4008

Merged
merged 3 commits into from
May 22, 2024

Conversation

CookiePieWw
Copy link
Collaborator

@CookiePieWw CookiePieWw commented May 21, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #4000

What's changed and what's your intention?

As title. Correct the failed fuzz seed FuzzInput { seed: 266, columns: 19, rows: 3995 }

The time index is treated as one of the primary keys for sorting. To compare the Value::Default with other values, all the default values in the insert_expr is replaced with its original value.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@CookiePieWw CookiePieWw requested a review from a team as a code owner May 21, 2024 16:35
@github-actions github-actions bot added docs-required This change requires docs update. docs-not-required This change does not impact docs. and removed docs-required This change requires docs update. labels May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 85.15%. Comparing base (4778575) to head (6105d0c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4008      +/-   ##
==========================================
- Coverage   85.50%   85.15%   -0.35%     
==========================================
  Files         977      977              
  Lines      169344   169446     +102     
==========================================
- Hits       144793   144296     -497     
- Misses      24551    25150     +599     

@CookiePieWw CookiePieWw marked this pull request as draft May 21, 2024 17:31
@CookiePieWw CookiePieWw marked this pull request as ready for review May 21, 2024 18:32
@WenyXu WenyXu requested review from evenyag and WenyXu May 22, 2024 02:38
@WenyXu WenyXu enabled auto-merge May 22, 2024 03:32
@WenyXu WenyXu added this pull request to the merge queue May 22, 2024
Merged via the queue into GreptimeTeam:main with commit 9800807 May 22, 2024
55 checks passed
@CookiePieWw CookiePieWw deleted the fix-insert-fuzz-sort branch May 22, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fuzz insert test failed
3 participants