-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzz insert test failed #4000
Comments
However, I didn't reproduce the bug in the standalone mode. |
And another failure is reported: https://github.com/GreptimeTeam/greptimedb/actions/runs/9171698235/job/25216790287 Failing input:
|
I reproduced the bug by:
The problem is:
|
@CookiePieWw Would you have any idea? Maybe we should sort the timestamp column + primary columns |
Maybe sort them with just primary keys is enough. The failure happens when there's the same timestamp and primary keys cannot be same. I wrongly took the timestampe columns as primary keys here before. Will make some changes later. |
Maybe we still need to sort with the timestamp column (i.g., sort with primary keys + timestamp )? For instance:
|
Ah you're right. The time index and primary keys uniquely define a row, instead of the primary keys only. |
Yes. Would you mind helping us fix this bug👀 |
Sure, already working on it :) |
Thanks!❤️ |
What type of bug is this?
Unexpected error
What subsystems are affected?
Storage Engine
Minimal reproduce step
FuzzInput
toOR
What did you expect to see?
Should pass the test
What did you see instead?
https://github.com/GreptimeTeam/greptimedb/actions/runs/9170138785/job/25211918959?pr=3998
What operating system did you use?
doesn't matter
What version of GreptimeDB did you use?
main
Relevant log output and stack trace
No response
The text was updated successfully, but these errors were encountered: