Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding node 18.x support #1266

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

devinmatte
Copy link

Fixes #1242

Node 18 is out, and the engine restrictions currently prevent it working on node 18. This simply adds node 18.x to the supported engines list

@google-cla
Copy link

google-cla bot commented Jul 26, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@devinmatte
Copy link
Author

@jakearchibald Sorry for the ping, you seem to be the last person who has contributed to this repo. Is this repo still maintained? If so, is someone able to help out with this PR and the related issue #1242?

@Antonio-Laguna
Copy link

@devinmatte is this the only required thing? I'm getting these errors if I ignore the engine:

(node:55337) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
node:internal/deps/undici/undici:4813
            throw new TypeError("Failed to parse URL from " + input, { cause: err });
                  ^

TypeError: Failed to parse URL from /node_modules/@squoosh/lib/build/imagequant_node-a4aafbae.wasm

@devinmatte
Copy link
Author

Looks like there's more to it. The issue is with the fetch API in node 18 it seems: node-fetch/node-fetch#1566

I can dive deeper into this, but looks like it's affecting a lot of projects, including another google repo google/draco#888

@Antonio-Laguna
Copy link

Yeah I assumed as much. Though looks like this is abandoned.

Are there any good alternatives?

@devinmatte devinmatte marked this pull request as draft August 8, 2022 13:37
@jakearchibald
Copy link
Collaborator

fwiw, my plan is to deprecate this (just the CLI/lib, not the site), since there isn't anyone to work on it, and no chance to hire people to work on it given the current economic climate. Folks are welcome to continue the work in a fork.

@ziemek99
Copy link
Contributor

ziemek99 commented May 28, 2023

Should be closed because of #1321. The original issue fixed by this PR, #1242, is closed as "not planned" as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for node engine 18 for @squoosh/lib
4 participants