Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swoosh not compatible with NodeJS 18 and being deprecated #6

Closed
rodrigolj opened this issue Nov 12, 2022 · 5 comments
Closed

Swoosh not compatible with NodeJS 18 and being deprecated #6

rodrigolj opened this issue Nov 12, 2022 · 5 comments

Comments

@rodrigolj
Copy link

Astro's image integration uses swoosh by default, which doesn't work with NodeJS 18 (required to run inkdrop-live-export). Also, it was said to being deprecated soon (GoogleChromeLabs/squoosh#1266 (comment)).

I suggest using the optional installation of sharp, as per the guide on the Astro documentation.

@craftzdog
Copy link
Owner

I guess you are talking about Squoosh.
Is the Astro team aware of it?

@rodrigolj
Copy link
Author

I guess you are talking about Squoosh.
Is the Astro team aware of it?

Yes. They said it won't be fixed by them, because it is an issue upstream. I tried your code with NodeJS 18 and the latest Astro, that's how I found the problem.

@craftzdog
Copy link
Owner

Hmm, node 18 is already in LTS so they should be on it though🤔
Can you tell me the issue URL where they said that?
Also, did using sharp solve it for you?

@rodrigolj
Copy link
Author

withastro/astro#5051

Using sharp solved it.

@craftzdog
Copy link
Owner

ah, node fetch doesn't support file URIs - makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants