Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR-4 #55

Closed
ls12styler opened this issue Oct 14, 2014 · 4 comments
Closed

PSR-4 #55

ls12styler opened this issue Oct 14, 2014 · 4 comments

Comments

@ls12styler
Copy link

http:https://www.php-fig.org/psr/psr-4/

This enables us to have a VendorName\PackageName namespace. I would suggest "php-gitlab-api\php-gitlab-api" as the vendor\package names. this may be better suited then in a GitHub organisation.
It would also allow the code structure to be a little bit neater.

It would also make the suggested adapter packages a little neater and easier to find.

Thoughts?

@hollodotme
Copy link

+1 :)

@ls12styler
Copy link
Author

Thanks for the +1.

Before we do this however, I think we should probably add some tests (#2), reformat the constructor args (#8) and tag as well (#53) as well as decide on a minimum supported version of PHP (#54)

@fbourigault
Copy link
Contributor

In #195, I changed the autoload config to use PSR-4 instead of deprecated PSR-0. I don't think changing namespace is a good idea as it's an heavy breaking change with near to 0 added value. What do you think about closing this issue?

@Nyholm
Copy link

Nyholm commented Aug 6, 2017

👍 for closing.

@m1guelpf m1guelpf closed this as completed Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants