Swap model constructor parameters around

[m4tthumphrey]

IE

$project = new Project($client, 1);

instead of

$project = new Project(1, $client);

This would make $client mandatory but it is always passed anyway so do not see any disadvantages to this.

[m4tthumphrey]

Another alternative is to get rid of non dependencies from constructors. Ie something like

$project = new Project($client);
$project->load(1);

etc...

Edit: I like this better.

[ls12styler]

I would agree on switching the arguments order. However I would still leave the current params in, but have them as optional

public function __construct(Client $client, $id = null, $data = [])

This gives the ability to create a Model instance with great flexibility over how/when you fetch/override the data.

I would also suggest that each Model has it's own hydrate method so we can remove the logic of (in the example of Project) the User::fromArray/ProjectNamespaces::fromArray calls out of the constructor.

[ls12styler]

I would also suggest this happens before the next re tagging, since it would be a major bump and breaking changes are acceptable.

[GrahamCampbell]

I think the plan is to remove models (eventually). We can close this off for now, since any refactoring tasks relating to models is not going to be worth it.