Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Version support #54

Closed
ls12styler opened this issue Oct 13, 2014 · 7 comments
Closed

PHP Version support #54

ls12styler opened this issue Oct 13, 2014 · 7 comments

Comments

@ls12styler
Copy link

What should be the minimum supported version of PHP? Considering 5.3 was released over 5 years ago and that 5.6 was recently released, I would suggest the library targets no less that 5.5.

@ls12styler ls12styler mentioned this issue Oct 14, 2014
@m4tthumphrey
Copy link
Contributor

I'm not sure I want to say 5.5 as there shouldn't be anything in 5.5 that we need to use. I would probably be ok with 5.4 but only if we come across an actual need for it (short array syntax, $this in closures). There's no point in making in 5.4/5.5 for the sake of it.

@jubianchi
Copy link
Contributor

@m4tthumphrey 👍

@ls12styler
Copy link
Author

That's fair. Means all the tests and changes I've made so far will have to be reverted to using 'array()' though. ^_^

Although, I could see the use of closures come in very handy for future uses. And having $this available would definitely be handy. Especially for callbacks after performing actions on the the GitLab API.

And don't forget, it's not just features you get, it's performance improvements and security fixes too!

This was referenced Feb 18, 2015
@m4tthumphrey m4tthumphrey modified the milestone: 8.0 Feb 18, 2015
@m4tthumphrey
Copy link
Contributor

I am thinking of going ahead with making the library PHP 5.4+ in the next major update

  • Guzzle4 requires 5.4
  • It's 2015

Thoughts? @ls12styler @hollodotme @jubianchi

@ls12styler
Copy link
Author

Anything is better than 5.3 :) so thumbs up from me.

@m4tthumphrey
Copy link
Contributor

Wow, glad we didn't switch to Guzzle4 as Guzzle is now on 6.2!

@fbourigault
Copy link
Contributor

I'm closing this issue as 9.0 will ne PHP 5.6+. See #195.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants