Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tab completion in Jupyter by inserting aliases into the method signature #1282

Merged
merged 14 commits into from
Jun 16, 2021
Merged
1 change: 1 addition & 0 deletions pygmt/helpers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from pygmt.helpers.decorators import (
deprecate_parameter,
fmt_docstring,
insert_alias,
maxrjones marked this conversation as resolved.
Show resolved Hide resolved
kwargs_to_strings,
use_alias,
)
Expand Down
27 changes: 27 additions & 0 deletions pygmt/helpers/decorators.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import functools
import textwrap
import warnings
from inspect import Parameter, signature

import numpy as np
from pygmt.exceptions import GMTInvalidInput
Expand Down Expand Up @@ -322,6 +323,30 @@ def fmt_docstring(module_func):
return module_func


def insert_alias(module_func, default_value=None):
"""
Decorator insertings aliases into the signature of a method.
maxrjones marked this conversation as resolved.
Show resolved Hide resolved
"""

# Get current signature and parameters
sig = signature(module_func)
wrapped_params = list(sig.parameters.values())
kwargs_param = wrapped_params.pop(-1)
# Add new parameters from aliases
for alias in module_func.aliases.values():
if alias not in sig.parameters.keys():
new_param = Parameter(
alias, kind=Parameter.KEYWORD_ONLY, default=default_value
)
wrapped_params = wrapped_params + [new_param]
all_params = wrapped_params + [kwargs_param]
# Update method signature
sig_new = sig.replace(parameters=all_params)
module_func.__signature__ = sig_new

return module_func


def use_alias(**aliases):
"""
Decorator to add aliases to keyword arguments of a function.
Expand Down Expand Up @@ -383,6 +408,8 @@ def new_module(*args, **kwargs):

new_module.aliases = aliases

new_module = insert_alias(new_module)
maxrjones marked this conversation as resolved.
Show resolved Hide resolved

return new_module

return alias_decorator
Expand Down