Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tab completion in Jupyter by inserting aliases into the method signature #1282

Merged
merged 14 commits into from
Jun 16, 2021
Merged

Support tab completion in Jupyter by inserting aliases into the method signature #1282

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8d21c1b
Try injecting one parameter into method signature
maxrjones May 21, 2021
8082150
Update decorator
maxrjones May 21, 2021
49aa7b5
Update decorator to work with all aliases
maxrjones May 21, 2021
c2a2979
Fix formatting errors
maxrjones May 21, 2021
c6477d7
Update function name
maxrjones May 21, 2021
d3a046e
Use insert_alias for all functions with use_alias
maxrjones May 22, 2021
cd12847
Revert "Use insert_alias for all functions with use_alias"
maxrjones May 23, 2021
dc25707
Call insert_alias from inside use_alias
maxrjones May 23, 2021
f37faea
Make inserted alias parameters KEYWORD_ONLY
maxrjones May 23, 2021
377ba97
Merge branch 'master' into inject-aliases
May 24, 2021
6ed7e93
Merge branch 'master' into inject-aliases
maxrjones Jun 2, 2021
3c63ecc
Apply suggestions from code review
maxrjones Jun 16, 2021
d0acb50
Merge branch 'master' into inject-aliases
seisman Jun 16, 2021
fcc0e34
Merge branch 'master' into inject-aliases
maxrjones Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make inserted alias parameters KEYWORD_ONLY
  • Loading branch information
@maxrjones
maxrjones committed May 23, 2021
commit f37faeaf519e7cbc6be9a5f5cd6b5086b1c1f500
4 changes: 2 additions & 2 deletions pygmt/helpers/decorators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ def fmt_docstring(module_func):
return module_func


def insert_alias(module_func):
def insert_alias(module_func, default_value=None):
"""
Decorator insertings aliases into the signature of a method.
"""
Expand All @@ -275,7 +275,7 @@ def insert_alias(module_func):
for alias in module_func.aliases.values():
if alias not in sig.parameters.keys():
new_param = Parameter(
alias, kind=Parameter.POSITIONAL_OR_KEYWORD, default=None
alias, kind=Parameter.KEYWORD_ONLY, default=default_value
)
wrapped_params = wrapped_params + [new_param]
all_params = wrapped_params + [kwargs_param]
Expand Down