List file to add extra exe's to the Win installer #909
Conversation
| @@ -70,6 +70,11 @@ if (FFTW3F_LIBRARY) | |||
| check_symbol_exists (fftwf_import_wisdom_from_filename fftw3.h FFTW3F_VERSION_RECENT) | |||
| cmake_pop_check_state() # restore state of CMAKE_REQUIRED_* | |||
|
|
|||
| # For some reason in my machine check_symbol_exists() call above is not able to its job | |||
There was a problem hiding this comment.
I don't think it's a good idea to commit your WIN32 trick here, since the Windows CI doesn't have such problem.
There was a problem hiding this comment.
Hmm, that change slipped in but I actually wanted to submit it as an separate PR. Yes, you are right that Windows CI does not seem to have that problem. But I do, and since it's me who makes the installers, I need to have it working preferably to always have an uncommitted change in my local repo (which the tyrant Git refuses to update)
There was a problem hiding this comment.
Any way to work around having to commit this into the FindFFTW.cmake file, i.e., via some conditional include statement or similar?
There was a problem hiding this comment.
I already wrapped it under a if (WIN32 AND NOT FFTW3F_VERSION_RECENT). According to the comment in line 69, this would only break for the case of someone building on windows with a static FFTW3 build. A case that as far as we know, never happened before, nor is likely to happen in a foreseeable future.
|
These changes were merged in #922. |
…ls#909) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.0.10 to v1.2.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v1.0.10...e156083) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
On Windows the installer ships with a complete GDAL + PROJ4 (V6). But for that I need to provide the list of the exe's to include in the installer. This file has that, but for my own paths.