Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a template for GMT release checklist #893

Merged
merged 19 commits into from
Jun 19, 2019
Merged

Add a template for GMT release checklist #893

merged 19 commits into from
Jun 19, 2019

Conversation

seisman
Copy link
Member

@seisman seisman commented Jun 13, 2019

Created an issue template for GMT release checklist. For each upcoming release, we can open an issue using this template, and tick them off one by one.

@seisman seisman changed the title Add a template for GMT release checklist WIP: Add a template for GMT release checklist Jun 13, 2019
@seisman
Copy link
Member Author

seisman commented Jun 13, 2019

Feel free to add more to the checklist!

Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add @remkos to the fink package update. We need to find someone to do macports as Florian is probably no longer available.

@PaulWessel
Copy link
Member

Do we tag after we build the tarballs? With svn we always made the 5.4.x tag and committed, then made the tarball etc so it would have the right settings.

@seisman
Copy link
Member Author

seisman commented Jun 14, 2019

I don't think tagging or not makes any differences in git. A tag is just a pointer to a specific commit hash.

In the checklist, I put tagging after making tarballs, because sometimes our tarballs/installers may not work as expected (e.g. #909). If we tag and push it to GitHub, then realize that our tarballs don't work well, we have to make a new tag (i.e. increasing GMT version number).

@seisman
Copy link
Member Author

seisman commented Jun 17, 2019

Need updates after we finish #962.

@leouieda
Copy link
Member

The only way the order would make a difference is if GMT used the git tag for something. But since the version number is set by cmake then it shouldn't matter.

@seisman seisman changed the title WIP: Add a template for GMT release checklist Add a template for GMT release checklist Jun 19, 2019
@seisman seisman requested a review from a team June 19, 2019 19:01
@seisman
Copy link
Member Author

seisman commented Jun 19, 2019

I updated the release checklist based on our release experience with 6.0.0rc1. This PR is ready for review.

@seisman seisman merged commit 7f026ee into master Jun 19, 2019
@seisman seisman deleted the release-checklist branch June 19, 2019 19:40
obaney pushed a commit to obaney/gmt that referenced this pull request Aug 18, 2021
…ppingTools#893)

Bumps [conda-incubator/setup-miniconda](https://github.com/conda-incubator/setup-miniconda) from v2.0.0 to v2.0.1.
- [Release notes](https://github.com/conda-incubator/setup-miniconda/releases)
- [Changelog](https://github.com/conda-incubator/setup-miniconda/blob/master/CHANGELOG.md)
- [Commits](conda-incubator/setup-miniconda@v2.0.0...73b9a80)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants