Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Build tests nightly #176

Closed
wants to merge 7 commits into from
Closed

WIP: Build tests nightly #176

wants to merge 7 commits into from

Conversation

seisman
Copy link
Member

@seisman seisman commented Nov 10, 2018

Description of proposed changes
IMHO, we still need to run tests to make sure that changes don't fail the test. Before #53 is solved, at least we can running the test nightly as a temporary fix.

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@joa-quim
Copy link
Member

There is no point in setting up the tests. Aside from the duration issue, we know for sure that they will fail. They will fail for two main reasons. One is that there are true failures. The other is that they currently are MACOS centric and when when run from Linux we’ll see many new failures due to tinny differences in PS.

We talked about this before, what we really need is to be to run code coverage to see what our test set does effectively tests. I believe that when we do it we can drop several tests ad find that we have adapt others. The problem is that making coverage of C code is not obvious, but GDAL is doing it. So it must be doable.

@PaulWessel
Copy link
Member

We need to discuss the purpose of the tests and better ways to arrange them . Joaquim is right that running all is not that helpful. Coverage is important and maybe a topic for discussion in Faro. Splitting the tests up is also needed, especially if we increase their numbers.

@seisman
Copy link
Member Author

seisman commented Nov 12, 2018

@PaulWessel @joa-quim OK, I'll close the PR.

BTW, the C code coverage seems straightforward with gcov and codecov.

@seisman seisman closed this Nov 12, 2018
@joa-quim
Copy link
Member

I tried gcov once but didn't have much success (or was it gperf?). But more than 15 min in unix start to give me head-aches so I gave up easily.

@seisman seisman deleted the travis-build-tests branch December 27, 2018 20:52
obaney pushed a commit to obaney/gmt that referenced this pull request Aug 18, 2021
)

Function `print_libgmt_info` is defined as a utility in
`gmt.__init__.py` so that we can diagnose bug reports. It is used before
the tests are run to make sure the info is present and we know which
version of the library is being used for testing.

Fixes GenericMappingTools#170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants