Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort and separate the tests scripts #53

Closed
leouieda opened this issue Aug 29, 2018 · 5 comments
Closed

Sort and separate the tests scripts #53

leouieda opened this issue Aug 29, 2018 · 5 comments
Labels
longterm Long standing issues that need to be resolved

Comments

@leouieda
Copy link
Member

GMT has a lot of test scripts that create and compare plots. What we don't have is a measure of how many modules these tests call and how much of the code is covered. The tests also take a long time to run so they're not good for running on TravisCI (we don't want to wait 40min for a build to finish).

Quoting @PaulWessel s email:

See plot of test durations (log-scale in seconds). So most are around a few seconds (1-10) with a few slow ones (70 s); this is on my laptop. I also attach the sorted list (time, test). Before I do anything else we can talk about what might be useful? Make a plot of “coverage” somehow, meaning how many times any gmt module is called within the 812 tests? I think we wanted a very basic set that at least ran all modules once on a minimal data set.

test-time-distribution
Distribution of test times.

Here is a file with the timing information for each test script: test_sorted.txt

@leouieda
Copy link
Member Author

To run these things on CI, it would be good to be able to specify different levels of tests that we want to run. Tests that are run on every build should be fast, ideally taking no more than 10min to run in total. We can run the full test suite with the slower tests on a nightly cron job. So it would help if we could "make test-fast" and "make test-full", for example.

@leouieda
Copy link
Member Author

cc @joa-quim @seisman

@seisman
Copy link
Member

seisman commented Oct 30, 2018

Inspired by https://github.com/obspy/obspy_github_api and https://github.com/obspy/obspy/blob/master/.travis.yml.

Maybe we can separate it into several tests, and use some magic comment strings like +DOCS, +TESTS:FULL, +TESTS:0 to trigger specific tests.

This was referenced Nov 9, 2018
@stale
Copy link

stale bot commented Jan 23, 2019

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@stale stale bot added the stale This will not be worked on label Jan 23, 2019
@leouieda leouieda added the longterm Long standing issues that need to be resolved label Jan 24, 2019
@stale stale bot removed the stale This will not be worked on label Jan 24, 2019
obaney pushed a commit to obaney/gmt that referenced this issue Aug 18, 2021
@maxrjones maxrjones added this to To Do in GMT testing improvements via automation Sep 9, 2021
@joa-quim
Copy link
Member

Closing on a too old and stalled criteria.

GMT testing improvements automation moved this from To Do to Done Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
longterm Long standing issues that need to be resolved
Development

No branches or pull requests

3 participants