Skip to content

Commit

Permalink
chore(ext/ffi): Remove unnecessary byte_offset conditional slicing (d…
Browse files Browse the repository at this point in the history
  • Loading branch information
aapoalas committed Jul 27, 2022
1 parent ffd74cb commit 8911bdb
Showing 1 changed file with 3 additions and 15 deletions.
18 changes: 3 additions & 15 deletions ext/ffi/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1030,11 +1030,7 @@ fn ffi_parse_pointer_arg(
type_error("Invalid FFI ArrayBufferView, expected data in the buffer")
})?
.get_backing_store();
if byte_offset > 0 {
&backing_store[byte_offset..] as *const _ as *const u8
} else {
&backing_store[..] as *const _ as *const u8
}
&backing_store[byte_offset..] as *const _ as *const u8
} else if let Ok(value) = v8::Local::<v8::BigInt>::try_from(arg) {
value.u64_value().0 as usize as *const u8
} else if let Ok(value) = v8::Local::<v8::Number>::try_from(arg) {
Expand Down Expand Up @@ -1592,11 +1588,7 @@ unsafe fn do_ffi_callback(
.buffer(scope)
.expect("Unable to deserialize result parameter.")
.get_backing_store();
if byte_offset > 0 {
&backing_store[byte_offset..] as *const _ as *const u8
} else {
&backing_store[..] as *const _ as *const u8
}
&backing_store[byte_offset..] as *const _ as *const u8
} else if let Ok(value) = v8::Local::<v8::BigInt>::try_from(value) {
value.u64_value().0 as usize as *const u8
} else if let Ok(value) = v8::Local::<v8::ArrayBuffer>::try_from(value) {
Expand Down Expand Up @@ -2039,11 +2031,7 @@ where
})?
.get_backing_store();
let byte_offset = value.byte_offset();
if byte_offset > 0 {
&backing_store[byte_offset..] as *const _ as *const u8
} else {
&backing_store[..] as *const _ as *const u8
}
&backing_store[byte_offset..] as *const _ as *const u8
} else if let Ok(value) = v8::Local::<v8::ArrayBuffer>::try_from(buf.v8_value)
{
let backing_store = value.get_backing_store();
Expand Down

0 comments on commit 8911bdb

Please sign in to comment.