chore(ext/ffi): Remove unnecessary byte_offset conditional slicing #15320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om TypedArray pointer handling
littledivy
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
LGTM.
It was panicking before because it was not using 0.. range:
let pointer = &backing_store[byte_offset] as *const _ as *const u8;See diff for #14997
Oooh, I must've been somehow quite tired when I was writing that... |
crowlKats
pushed a commit
that referenced
this pull request
Aug 4, 2022
aapoalas
deleted the
chore-ext-ffi-remove-unnecessary-backing-store-slicing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously I got panics in pointer TypedArray handling with empty arrays from slices with byte_offset as zero. I even checked it multiple times.
Somehow, that no longer occurs and these conditional slice handlings are unnecessary.