[WIP] LLVM term annotations #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdockins
force-pushed
the
rwd/llvm-annotations2
branch
from
1f73d60
to
01bfa07
Compare
andreistefanescu
force-pushed
the
rwd/llvm-annotations2
branch
2 times, most recently
from
5f0669c
to
54b65d8
Compare
These are: incomplete-patterns, overlapping-patterns, and missing-methods.
Remove the use of the `WithAssertions` expression former in crucible-llvm. Instead, a language-extension expression former `LLVM_SideConditions` has been added that directly references the `LLVM_SafetyCondition` type. Remove the `WithAssertions` syntax constructor and related typeclass constraints.
mechanism, and the `HasStructuredAssertions` typeclass. These ideas are largely being replace with term annotations.
andreistefanescu
force-pushed
the
rwd/llvm-annotations2
branch
from
54b65d8
to
0622138
Compare
|
I'm not convinced about 0622138 at all; |
|
|
|
Ah, I see. Yeah, tracing it back, it looks like all call sites come from places where it is plausible that the values should be structurally compatible. I'll add a comment to that effect. |
kquick
added a commit
to GaloisInc/macaw
that referenced
this pull request
Aug 9, 2020
kquick
added a commit
to GaloisInc/semmc
that referenced
this pull request
Aug 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another, more cleaned-up take on addressing #425