Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AssertionTree with predicate annotations #425

Closed
robdockins opened this issue Jan 29, 2020 · 2 comments
Closed

Replace AssertionTree with predicate annotations #425

robdockins opened this issue Jan 29, 2020 · 2 comments

Comments

@robdockins
Copy link
Contributor

The AssertionTree datastructure does not have explicit sharing, and is probably the reason for the slowdown described in #407.

Rather than rework this datastructure to preserve sharing, I think it makes more sense to allow what4 predicates to be labeled with annotations. These annotations can later be traversed to build the kind of user-visible explanations that AssertionTree is currently used for. This will both simplify the API and, hopefully, alleviate a performance problem.

@robdockins
Copy link
Contributor Author

CF #441.

@robdockins
Copy link
Contributor Author

Annotations are now used instead of assertion trees. Next we need to implement #462 to actually use the embedeed annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant