Adapt to Call/CallBr having raw function types
#1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kquick
approved these changes
Mar 20, 2023
langston-barrett
approved these changes
Mar 21, 2023
There are a handful of places in `crucible-llvm` where we assume that the `Call` and `CallBr` instructions have pointer types. As noted in GaloisInc/llvm-pretty-bc-parser#189, however, this is subtly incorrect. This patch: * Bumps the `llvm-pretty-bc-parser` submodule to bring in the changes from GaloisInc/llvm-pretty-bc-parser#207, which corrects this mistake. * Bumps the `llvm-pretty` submodule to be in tandem with `llvm-pretty-bc-parser`. Note that because this brings in the changes from GaloisInc/llvm-pretty#104, I opted to explicitly disallow LLVM's opaque pointers in `crucible-llvm` for now, but this is something that will likely change in subsequent patches. * Changes the parts of `crucible-llvm` that match on pointer types to no longer do so.
|
Ah, the changes from GaloisInc/llvm-pretty-bc-parser#202 will require using a build plan that supports |
This requires bumping the `what4` submodule to bring in the changes from GaloisInc/what4#233, which adds support for `tasty-sugar-2.1.*` on the `what4` side.
kquick
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a handful of places in
crucible-llvmwhere we assume that theCallandCallBrinstructions have pointer types. As noted in GaloisInc/llvm-pretty-bc-parser#189, however, this is subtly incorrect. This patch:llvm-pretty-bc-parsersubmodule to bring in the changes from Givecall/callbrfunction types instead of pointer types llvm-pretty-bc-parser#207, which corrects this mistake, andcrucible-llvmthat match on pointer type to no longer do so.