Basic support for opaque pointers #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds basic support for representing and pretty-printing opaque `ptr` types, which were introduced in LLVM 13 as part of a longer-term plan to stop using non-opaque pointer types (e.g., `i8*`). See https://llvm.org/docs/OpaquePointers.html for further details. The next step in `llvm-pretty` is to make sure that all of the instructions that involve pointers in some way (e.g., `call`) have all the information that they need to work with opaque pointers. I will be addressing this in subsequent commits. This is one step towards #102.
Previously, the code in `ppCallSym` assumed that the function type stored in a `call` instruction was a pointer type, but this should actually be a raw function type. See the discussion at GaloisInc/llvm-pretty-bc-parser#189 (comment) for more on this. We now assume the convention of raw function types in `call` instructions, as well as the related `callbr` and `invoke` instructions. This addresses one part of #102.
langston-barrett
approved these changes
Mar 21, 2023
elliottt
approved these changes
Mar 21, 2023
RyanGlScott
added a commit
to GaloisInc/crucible
that referenced
this pull request
Apr 3, 2023
There are a handful of places in `crucible-llvm` where we assume that the `Call` and `CallBr` instructions have pointer types. As noted in GaloisInc/llvm-pretty-bc-parser#189, however, this is subtly incorrect. This patch: * Bumps the `llvm-pretty-bc-parser` submodule to bring in the changes from GaloisInc/llvm-pretty-bc-parser#207, which corrects this mistake. * Bumps the `llvm-pretty` submodule to be in tandem with `llvm-pretty-bc-parser`. Note that because this brings in the changes from GaloisInc/llvm-pretty#104, I opted to explicitly disallow LLVM's opaque pointers in `crucible-llvm` for now, but this is something that will likely change in subsequent patches. * Changes the parts of `crucible-llvm` that match on pointer types to no longer do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of two patches that make it possible for
llvm-prettyto handle opaque pointers and pretty-print them correctly when used in acallinstruction, the latter of which was prompted by GaloisInc/llvm-pretty-bc-parser#189 (comment).This is likely not everything that we will need to handle everything opaque pointer–related, but it is a good starting point. See #102 for the long-term goal of robustly supporting opaque pointers.