Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminators update #1990

Closed
9 tasks done
nathandunn opened this issue Dec 14, 2018 · 24 comments
Closed
9 tasks done

terminators update #1990

nathandunn opened this issue Dec 14, 2018 · 24 comments
Assignees
Labels
Milestone

Comments

@nathandunn
Copy link
Contributor

nathandunn commented Dec 14, 2018

  • add sprite for termintator

    • create terminator features with a strand
    • return terminator features with a strand
    • make sure that it returns features with that strand in place
  • disallow changing terminator types

  • fix width of popup

  • remove menu options

  • remove server calls

    • fix REST calls
@nathandunn nathandunn added this to the 2.3 milestone Dec 14, 2018
@nathandunn nathandunn self-assigned this Jan 9, 2019
@ghost ghost added the in progress label Jan 9, 2019
@nathandunn
Copy link
Contributor Author

Quick question: @jasonjgill / @meiliuCPT / @jrr-cpt

I am assuming that you are wanting to associate a terminator with multiple isoforms?

I have a few questions:

1 - is the relationship to that isoform always going to be the same (I would assume so)., or are there other properties you might try to annotate?
1a - our default relationship between features (isoform being parent and terminator being the child) is part_of . . I'm hoping that is sufficient, but if there is a better SO / GO definition, that is okay.
2 - do you have a png associated with this?

@nathandunn
Copy link
Contributor Author

3 - should a lookup of "near" isoforms be provided? Say, less than 100 bp (or pick a number)?

@nathandunn
Copy link
Contributor Author

nathandunn commented Jan 10, 2019

This is roughly what I'm envisioning, but not sure if its overkill or not. The icons for the terminator might need to be added, as well.

@jasonjgill / @meiliuCPT / @jrr-cpt is this roughly what you were envisioning?

(removed)

@nathandunn
Copy link
Contributor Author

Sorry, the single entry for transcript should not be there.

The new section would be the "associated transcripts" section, which would be autofilled with upstream isoforms.

phageexample

@nathandunn
Copy link
Contributor Author

4 - Would you ever have a set of isoforms for a single gene where some mRNA would correspond to the terminator and some would not or would it always be safe to associate a terminator to all mRNA for a gene?

@nathandunn
Copy link
Contributor Author

Won't need association data at this point. So, we can get rid of a lot of the association stuff and add the png and be done.

@jasonjgill
Copy link

jasonjgill commented Jan 11, 2019 via email

@jasonjgill
Copy link

jasonjgill commented Jan 11, 2019

here is our proposed glyph for transcriptional terminators.
apollo term glyph 2

since terminators are directional, the glyph should have the ball on top for terminators pointing rightwards (i.e., on the top strand) and be upside-down for terminators on the bottom strand.

@nathandunn nathandunn changed the title terminators should be able to be associated with an mRNA terminators update Jan 11, 2019
@nathandunn
Copy link
Contributor Author

nathandunn commented Jan 11, 2019

  • add termintator sprint for 16x16 (or close) (should work for data around 200-150 bp)
  • add a negative terminator flipped over

Resize command:

convert terminator.png -resize 16.x16 terminator16.png

Not sure how to sure how to use convert to do this, but can pull into another program to do the same http:https://www.imagemagick.org/Usage/resize/#resample

@nathandunn
Copy link
Contributor Author

@jasonjgill Will the width of a terminator typically be 10-50 bps?

@nathandunn
Copy link
Contributor Author

Or are you counting the hairpin, etc. (200+ bp) or just a single point for the terminator (at the start for instance)?

Also, if you are going to have an icon and a block, do you want the icon at the downstream end of the block or the upstream?

@nathandunn nathandunn modified the milestones: 2.3, 2.2.1 Jan 17, 2019
@jasonjgill
Copy link

We annotate these terminators as the hairpin plus the poly-T tail, so the features are usually around 20-25 bp long. I guess it makes the most sense for the glyph to be at the downstream (3') end of the feature,

@nathandunn
Copy link
Contributor Author

Sprint added successfully. Having trouble detecting strand on this.

@nathandunn
Copy link
Contributor Author

Adding notes to the top

@jasonjgill
Copy link

What is the problem with detecting strand? The tool should assign the terminator to base coordinates and a strand...

@nathandunn
Copy link
Contributor Author

nathandunn commented Jan 19, 2019 via email

@nathandunn
Copy link
Contributor Author

I'm not going to be able flip the widget as far as I can tell, but I think this is fairly straight-forward, still.

image

@nathandunn
Copy link
Contributor Author

  • strand on the left, and negative strand on the right

@nathandunn
Copy link
Contributor Author

nathandunn commented Jan 21, 2019

the other mode I has was this, but I like itless.:
image

@nathandunn
Copy link
Contributor Author

I'm not going to be able flip the widget as far as I can tell, but I think this is fairly straight-forward, still.

image

@nathandunn
Copy link
Contributor Author

@jasonjgill I'm going to merge this in for completeness, but we can make changes later as needed.

@ghost ghost removed the in progress label Jan 21, 2019
@jasonjgill
Copy link

OK. If it's going to be like an end cap on the feature, maybe I could get rid of the stick in the glyph?

@nathandunn
Copy link
Contributor Author

@jasonjgill They're pretty easy for me to update in preview (if I understood you correctly).

I think this looks much better this way. Let me know.

screen shot 2019-01-21 at 1 37 03 pm

@jasonjgill
Copy link

That's perfect, thanks!

@nathandunn nathandunn modified the milestones: 2.2.1, 2.3 Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants