Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Github Actions #2

Merged
merged 7 commits into from
Apr 26, 2022
Merged

Support for Github Actions #2

merged 7 commits into from
Apr 26, 2022

Conversation

gaby
Copy link
Contributor

@gaby gaby commented Apr 24, 2022

The purpose of this PR is to automate the testing of new PR's and code changes to StoreDown

It seems like some code changes need to happen, since npm build is failing with the following:

This relative module was not found:

* ../../../storedown-common/Database.js in ./src/services/Database.js

Unless I'm missing something?

@gaby
Copy link
Contributor Author

gaby commented Apr 24, 2022

@FoxUSA I have several questions:

  • Should I keep support for macos and windows during tests?
  • Should Node 14 and 16 be the only versions tested against or should I add any other?
  • Do you know why npm build is complaining about relative paths?

I basically tried to simulate the same commands you have in https://github.com/FoxUSA/StoreDown/blob/master/docs/development.md

@gaby gaby mentioned this pull request Apr 24, 2022
5 tasks
@gaby
Copy link
Contributor Author

gaby commented Apr 24, 2022

I can't seem to find ../../../storedown-common/Database.js in the source code.

@gaby
Copy link
Contributor Author

gaby commented Apr 24, 2022

The development.md states to run npm run install but that command doesn't exist.

FoxUSA pushed a commit that referenced this pull request Apr 24, 2022
@FoxUSA
Copy link
Owner

FoxUSA commented Apr 24, 2022

@gaby we can trade mistakes. I forgot a file. In your command you added run. It should be just npm install. I checked and that is what is in the docs.

This file use to be in its own module because I intended to abstract shared code out for use in a cli and plugins like an Alexa skill. That work tree died out so I just included the function.

@gaby
Copy link
Contributor Author

gaby commented Apr 24, 2022

Awesome @FoxUSA can you approve the workflow, to see if it passes?

@gaby
Copy link
Contributor Author

gaby commented Apr 24, 2022

I'm running the CI here https://github.com/gaby/StoreDown/runs/6149642317?check_suite_focus=true

So far everything went fine until npm run test:unit were it fails

@gaby
Copy link
Contributor Author

gaby commented Apr 25, 2022

I just removed the unit:test stage since it's not actually doing anything. Running the e2e on GitHub requires a separate PR.

For now this PR is:

  • Installing dependencies
  • Running npm build
  • Running lint test

Should be good to merge :-)

@FoxUSA
Copy link
Owner

FoxUSA commented Apr 25, 2022

@gaby
I will accept this pull request if it is given under a MIT License

@gaby
Copy link
Contributor Author

gaby commented Apr 25, 2022

@FoxUSA Yes, it's under MIT License, same as this repo.

@FoxUSA FoxUSA merged commit d1c3f81 into FoxUSA:master Apr 26, 2022
@gaby gaby deleted the ci-support branch April 26, 2022 02:04
@FoxUSA
Copy link
Owner

FoxUSA commented Apr 26, 2022

@gaby thank you for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants