Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Docker support #1

Closed
wants to merge 6 commits into from
Closed

Full Docker support #1

wants to merge 6 commits into from

Conversation

gaby
Copy link
Contributor

@gaby gaby commented Apr 24, 2022

The purpose of this draft PR is to track adding support for Docker as requested by various users on Reddit.

  • Add Docker Ignore
  • Add Dockerfile with Multi-Stage support
  • Update README with instructions on how to use Docker Image
  • Provide example docker-compose.yml for running StoreDown
  • Add support for building, tagging, and releasing StoreDown images to ghcr.io and possibly DockerHub

@FoxUSA Do you currently have an account for StoreDown in hub.docker.com ? If not, can you create one under storedown username. That way the image can be created as storedown/storedown:latest

@gaby gaby changed the title Add dockerignore file Full Docker support Apr 24, 2022
@FoxUSA
Copy link
Owner

FoxUSA commented Apr 24, 2022

Ahh fine.
I thought folks may want to just plop this on a web server of their choice .
I have supported Docker and provided compose instruction on other project in the past.

This app follows that same pattern.

@gaby
Copy link
Contributor Author

gaby commented Apr 24, 2022

From what I can see it's quite easy to download your artifacts and run them in a web server, but a lot of people prefer to just docker run an existing image to facilitate automation, etc.

I'm working on PR #2 first, since that one seems crucial before starting to build/publish Docker Images.

@gaby gaby marked this pull request as ready for review April 25, 2022 13:21
@gaby
Copy link
Contributor Author

gaby commented Apr 25, 2022

@FoxUSA PR is ready

Final Docker image is 27.3 MB served using NGINX

Screenshots:

image

image

image

@gaby
Copy link
Contributor Author

gaby commented Apr 26, 2022

  • Updated README with instructions for running the Docker container
  • Included an example docker-compose file for running StoreDown.

@gaby
Copy link
Contributor Author

gaby commented Apr 26, 2022

@FoxUSA where is the data from the Docker Container stored? So I can add it to the example.

Dockerfile Outdated Show resolved Hide resolved
FoxUSA pushed a commit that referenced this pull request Apr 26, 2022
@FoxUSA FoxUSA mentioned this pull request Apr 26, 2022
@gaby
Copy link
Contributor Author

gaby commented Apr 26, 2022

@FoxUSA I'm confused, did you rugpull my PR by merging a Dockerfile into master?

@gaby
Copy link
Contributor Author

gaby commented Apr 26, 2022

👎🏻 closing this

@gaby gaby closed this Apr 26, 2022
@gaby gaby deleted the docker-support branch April 26, 2022 02:26
@FoxUSA
Copy link
Owner

FoxUSA commented Apr 26, 2022

@FoxUSA I'm confused, did you rugpull my PR by merging a Dockerfile into master?

@gaby Nope. I just had limited time yesterday and I told folks I would have Docker stuff on Monday.

Should note I use this everyday, so I had to document my personal Docker install and migrate that to the container I built.
So the methods were slightly different.

Thank you for this PR.

@FoxUSA
Copy link
Owner

FoxUSA commented Apr 26, 2022

  • I had questions about the GitHubs registry, the reason for the NGINX config.
  • Then I need to just resolve the minor conflicts.

FoxUSA added a commit that referenced this pull request May 4, 2022
* Added info on #1

* Issue #5 work

* Turns out I own the domain

* Resolves #8
FoxUSA added a commit that referenced this pull request May 19, 2022
* Added info on #1
* Issue #5 work
* Resolves #8
* Fixes #10. 
* Added tests. 
* Added automatic deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants