Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding results for sprint 2 #13

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Conversation

hannahbrucemacdonald
Copy link
Contributor

This PR adds the files used to make purchasing decisions for the second covid-moonshot sprint.

Details are outlined in the README.md. The 24 molecules proposed for purchasing are in purchasing.csv, however contain three uncertain esters, which may be removed.

Copy link
Member

@jchodera jchodera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Can you just add a ### Manifest section where you describe what the checked in files are to the README.md?

@hannahbrucemacdonald hannahbrucemacdonald merged commit 07d70a2 into master Aug 26, 2020
@hannahbrucemacdonald hannahbrucemacdonald deleted the sprint2-purchasing branch August 26, 2020 08:48
@PantherX
Copy link

Hiya @hannahbrucemacdonald
I spotted this in the purchasing CSV file where row 8 has an extra column due to , similar to EN300-382173 and not sure where it will be imported into but an option would be to add a column "Notes" and while it can be blank for all rows (simply have , at the end of all those rows), it will be populated for row 8 😃

@jchodera jchodera mentioned this pull request Aug 28, 2020
@hannahbrucemacdonald
Copy link
Contributor Author

Ah good spot @PantherX ! I should be more careful where I scribble stuff! Adopting the format you suggest now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants