This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Add interfaces for data structures #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firehed
commented
May 27, 2019
|
|
||
| public function getSignature(): string; | ||
|
|
||
| public function getSignedData(): string; |
There was a problem hiding this comment.
This should, in principle, be identical across all formats, and liable to be adjusted or removed (this should always be authData | sha256(clientData), where authData is sha256(rpID) | userPresence | counter)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on #4
The request side still needs a bit of work, but this decouples the response handling of the server from specific formats and changes the focus to be the high-level procedure.
Most notably, the "what data should have been signed?" shifts into the response structures, which not only is critical for basic WebAuthn support (#2), but potentially other attestation formats.
This may be adjusted slightly before the 2.0 tag.