Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Interfaces for Registration and Request (and SignRequest…)? #4

Closed
matthewslouismarie opened this issue Apr 29, 2018 · 3 comments · Fixed by #11
Closed

Interfaces for Registration and Request (and SignRequest…)? #4

matthewslouismarie opened this issue Apr 29, 2018 · 3 comments · Fixed by #11

Comments

@matthewslouismarie
Copy link
Contributor

Just a potential improvement that could be made to the library to improve interoperability. I'm working on a library that uses Firehed U2F, but because I only want to expose interfaces I have to convert Registration, SignRequest, etc. objects into implementations of interfaces (e.g. IU2fRegistartion, etc.)

I believe it would be better if there were some standard interfaces that U2F objects could implement.

@Firehed
Copy link
Owner

Firehed commented Apr 29, 2018

This is a great idea, and I will look into setting it up soon (or review a pull request, if you’d like to take that approach)

@matthewslouismarie
Copy link
Contributor Author

I could do that, yes! :)

@Firehed
Copy link
Owner

Firehed commented Apr 29, 2018

Thanks! In case you haven't seen it, it's probably worth reading this since there's probably some small amount of overlap.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants