This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Webauthn support #11
Merged
Webauthn support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
============================================
Coverage 100.00% 100.00%
- Complexity 103 134 +31
============================================
Files 18 21 +3
Lines 360 545 +185
============================================
+ Hits 360 545 +185
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2, closes #1
For the most part, this is just a tremendous amount of format shifting, and some updated demo code which should get migrated to Firehed/u2f-php-examples. Thanks to the new interfaces introduced in 1.1.0, there should be no breaking changes.
Right now, this needs the following changes:
Server
code to ensure no weird cross-origin/Relying Party issues are exposedAlso, it would be worth considering other formats and verification procedures, though that's out of scope for now (basically the entirety of WebAuthn section 8)