Resolved #4227 where expire_session_on_browser_close config override was not always respected

[intoeetive]

Resolved #4227 where expire_session_on_browser_close config override was not always respected

EE7 version of #4242

[robinsowell]

So it's weird, but it doesn't seem to do anything with regard to the session expiration. Also.... wouldn't this skip the cookie registry check for all cookies, not just sessions. I'm pretty sure it's only that session cookie that's supposed to be affected by the setting.

[robinsowell]

Also... the more I think on it, the more I start to lean toward removing it entirely. We can manage the session cookie length in the cookie settings now, which I believe would keep it in line with the cookie consents. Which it... probably should be? Though granted, the setting can only make it more private, not less.

Weird that didn't fix it, though. But it definitely didn't for me.

[intoeetive]

Right, you could just set the value to 0 and that will do it.

[intoeetive]

@robinsowell upon further thinking, I think we still need to make override work for sake of upgraded sites.

Please check the new version I just pushed

[robinsowell]

I'm not sure why, but it still doesn't seem to be working.

$config['expire_browser_on_session_close'] = 'y';

I tried logging into the backend, logging into the frontend- both running cookies only for session setting. Running EE 7.4.8, I even grabbed a fresh system/ee folder, then dropped the new file into that.