Session expire_browser_on_session_close doesn't work with cookie consent

[robinsowell]

Configuration override should cause session cookies to expire on close, and I couldn't figure out why it wasn't working.

Looks like in Input class

        // check the cookie setting for expiration date
        if (is_numeric($data['expire'])) {
            $loadedCookieSettings = ee('CookieRegistry')->getCookieSettings($name);
            if (!empty($loadedCookieSettings)) {
			
			log_message('error', 'input first: ' . ' - ' . $data['expire']);
				
                if ($loadedCookieSettings['cookie_lifetime'] === null) {
                    $cookieSettings = ee('Model')->get('CookieSetting')->filter('cookie_name', $name)->first();
                    $cookieSettings->cookie_lifetime = $data['expire'];
                    $cookieSettings->save();
                    ee('CookieRegistry')->registerCookieSettings($cookieSettings);
                } else {
                    if (is_numeric($loadedCookieSettings['cookie_lifetime'])) {
                        $data['expire'] = ($loadedCookieSettings['cookie_enforced_lifetime'] !== null) ? $loadedCookieSettings['cookie_enforced_lifetime'] : $loadedCookieSettings['cookie_lifetime'];
                    }
                }
				
				log_message('error', 'input second: ' . ' - ' . $data['expire'] . ' _ ' . $data['name']);
            }
        }

That's overriding it with whatever is set in the cookie register settings.

Since you can set the duration in the cookie settings, seems like we should probably just remove this on? Possibly logging it as deprecated so they'll know what's happening if it was working prior to an upgrade and now doesn't.