Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the NeoX implementation of GPT2Tokenizer #1042

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Remove the NeoX implementation of GPT2Tokenizer #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6b1bb1
Try out just using the HF implementation
dashstander Sep 25, 2023
3f8c63c
Rely solely on HF tokenizer.
dashstander Sep 25, 2023
12165fb
Update NeoXArgs docs automatically
invalid-email-address Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion configs/neox_arguments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ Logging Arguments

- **git_hash**: str

Default = 1f832c1
Default = 3f8c63c

current git hash of repository

Expand Down
368 changes: 0 additions & 368 deletions megatron/tokenizer/gpt2_tokenization.py
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion megatron/tokenizer/tokenizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import numpy as np
import sentencepiece as spm
from typing import List, Union
from .gpt2_tokenization import GPT2Tokenizer


def build_tokenizer(args):
Expand Down