Remove the NeoX implementation of GPT2Tokenizer #1042
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was noted in #999, the name
GPT2Tokenizer
was shadowed, imported from both HuggingFacetransformers
and from our own implementation of the same class. It would only have been used if someone set"tokenizer_type": "GPT2BPETokenizer"
, as otherwise the HuggingFace "fast" tokenizer would be used. In my tests they appear to be equivalent, so this means one less file to maintain.